Uh oh!
There was an error while loading. Please reload this page.
fix(integrations): gdrive trashed search, slack blocks-with-file, slack get_message ts - #4600
Conversation
…ck get_message ts - Google Drive search/list: skip default `trashed = false` when user query already specifies a `trashed = ...` predicate, so trashed-file searches work. - Slack send-message with files: forward `blocks` through to `files.completeUploadExternal` so Block Kit renders when files are attached. - Slack get_message: switch from `conversations.history` (oldest lower-bound returned the next message after) to `conversations.replies` with `ts=` for exact-match lookup, plus a defensive ts-equality guard and clearer error.
The latest updates on your projects. Learn more about Vercel for GitHub. |
PR SummaryMedium Risk Overview Improves Slack integrations by forwarding Reviewed by Cursor Bugbot for commit db18b88. Configure here. |
Greptile SummaryThis PR fixes three independent integration bugs across Google Drive search, Slack file-upload messages, and Slack message retrieval.
Confidence Score: 5/5All four changes are narrow, targeted bug fixes with no side-effects on happy-path inputs. Each fix is tightly scoped: the trashed-guard regex only fires when the user explicitly writes a No files require special attention. Important Files Changed
Reviews (3): Last reviewed commit: "fix(slack): omit initial_comment when bl..." | Re-trigger Greptile |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
…, not gdrive syntax
waleedlatif1
commented
May 14, 2026
waleedlatif1
commented
May 14, 2026
@cursor review |
Uh oh!
There was an error while loading. Please reload this page.
…ually renders on file uploads
waleedlatif1
commented
May 14, 2026
waleedlatif1
commented
May 14, 2026
@cursor review |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit db18b88. Configure here.
Summary
trashed = false. Now skipped when the user query already specifies atrashed = ...predicate, so searching for trashed files actually works. Drive'sfiles.listhas no implicit trash filter — the caller ownsq.blocksthroughcompleteSlackFileUploadtofiles.completeUploadExternalso Block Kit renders when a file is attached. Slack acceptsblockson that endpoint; we just weren't passing it.conversations.history(oldestis a lower-bound, returned the next message after when input ts didn't exactly match) toconversations.replieswithts=for deterministic single-message lookup. Added a defensive ts-equality guard and a clearer "Message not found at timestamp X" error.Type of Change
Testing
Tested manually against the API behavior described in each bug report.
bun run check:api-validationpasses. No happy-path behavior changes — only the bug-triggering inputs change behavior.Checklist