Uh oh!
There was an error while loading. Please reload this page.
v0.6.90: resource breadcrumb flash fix, dedupe external URL fetches, fal-ai hosted key - #4734
Conversation
…g on load (#4732) * improvement(kb-connectors): align connector UI surfaces and strip redundant description suffix - Fix icon colors to use --text-icon token across connector cards and modal - Switch Reconnect/Update access buttons from active to primary variant - Lift search box surface from --surface-2 to --surface-3 so it's visible against modal bg - Replace raw <button> elements with emcn Button in base.tsx - Shrink Connected Sources modal from lg to md - Strip " to/into/from your knowledge base" from all 27 connector descriptions to prevent overflow * fix(resource): replace raw pagination button with emcn Button * fix(resource): prevent permission-gated breadcrumb items from flashing on load * fix(resource): self-remove keydown listener on Escape and include session loading in isLoading guard
* fix(files): never dedup external URL fetches by path filename External URL fetches in the file parse route were keyed on the path filename, so two distinct URLs whose paths ended in `image.png` (e.g. every Slack clipboard paste) collided in the workspace cache and returned stale bytes from a prior fetch. Extracts the fetch + save flow into `fetchExternalUrlToWorkspace` so the broken dedup pattern can't be reintroduced. The helper always downloads; `uploadWorkspaceFile` handles name collisions on save by suffixing (`image.png` -> `image (1).png` -> ...). * fix(files): distinguish non-member from read-only in workspace-save skip log Splits the workspace-save skip branch so non-members (permission === null) log 'user is not a workspace member' instead of the misleading 'lacks write permission'. Adds a test covering the null case so the relaxed behavior (vs. the prior route's hard 'File not found') is explicit.
The latest updates on your projects. Learn more about Vercel for GitHub.
|
PR SummaryMedium Risk Overview Adds explicit handling for Prevents permission-gated breadcrumb/actions from flashing during initial load by treating Reviewed by Cursor Bugbot for commit 6b1210b. Configure here. |
Greptile SummaryThis PR ships two targeted fixes: it prevents permission-gated breadcrumb items from visually flashing on initial load by factoring session-loading state into the
Confidence Score: 5/5Safe to merge — both fixes are narrow and well-tested, no regressions in auth or data paths. The external-URL dedup removal is backed by targeted unit tests in both the new helper and the existing route test suite. The session-loading breadcrumb fix is a small, isolated change to the permissions hook that only adds isPending to the loading guard. All connector description changes are cosmetic. The resource.tsx context-menu state tracking uses correct closure references in cleanup and the DataRow highlight logic is non-breaking. No files require special attention. Important Files Changed
Reviews (1): Last reviewed commit: "fix(files): never dedup external URL fet..." | Re-trigger Greptile |
…i for image/video gen, search visibility in cmd-k (#4684) * improvement(media-gen): retire vision block, add hosted key for fal ai for image/video gen * address comments
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.