Uh oh!
There was an error while loading. Please reload this page.
fix(integrations): stop browser autofilling the service account API token field - #4973
Conversation
The latest updates on your projects. Learn more about Vercel for GitHub. |
PR SummaryLow Risk Overview The token field now uses Reviewed by Cursor Bugbot for commit c948ba4. Configure here. |
Greptile SummaryThis PR fixes Chrome's password-manager autofill on the Atlassian service-account API token field by replacing the raw Confidence Score: 5/5Single-field UI fix with no logic changes; safe to merge. The change is a direct swap of one input variant for the canonical SecretInput component already used elsewhere in the codebase. The submit-path validation is unchanged, state management is unchanged, and the autofill-blocking attributes are applied correctly. No new risk is introduced. No files require special attention. Important Files Changed
Sequence DiagramsequenceDiagram
participant Browser as Browser / Password Manager
participant Input as SecretInput (type=text)
participant State as React State (apiToken)
Note over Browser,Input: Before fix: type=password triggered autofill
Browser--xInput: "autoComplete='off' ignored on type=password"
Note over Browser,Input: After fix: type=text + blur-masking
Browser->>Input: Page load (input not focused)
Input->>Input: "displayValue = bullets (value.length)"
Note over Browser: No password field detected, no autofill
Browser->>Input: User focuses input
Input->>Input: "isFocused = true, displayValue = real value"
Browser->>Input: User types / pastes token
Input->>State: onChange(e.target.value) only when focused
Browser->>Input: User blurs
Input->>Input: "isFocused = false, displayValue = bullets"
Note over Browser: Synthetic autofill event while blurred is discarded
Reviews (2): Last reviewed commit: "fix(integrations): stop browser autofill..." | Re-trigger Greptile |
a2d41f5 to
c948ba4Comparewaleedlatif1
commented
Jun 11, 2026
waleedlatif1
commented
Jun 11, 2026
@cursor review |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit c948ba4. Configure here.
Uh oh!
There was an error while loading. Please reload this page.
Summary
autocomplete='off'ontype='password'inputsSecretInput(viaChipModalField type='custom'), matching the existing MCP Client Secret field: plaintype='text'with blur-masking so password managers have nothing to target, plus it discards synthetic autofill change events while blurredautoComplete='new-password',data-lpignore,data-form-type)Type of Change
Testing
Tested manually
Checklist