Uh oh!
There was an error while loading. Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork 3.8k
feat(mship): add parallel subagents, improve streaming performance#5122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
Changes from all commits
1a4518ab6c30185f836dad96638ec4180cd1872b29f09cd98a43c647ed9d5ba9f2cc029199758dfe879c45a53c4File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -196,6 +196,7 @@ | ||
| "sixtyfour", | ||
| "slack", | ||
| "smtp", | ||
| "sportmonks", | ||
| "sqs", | ||
| "square", | ||
| "ssh", | ||
Large diffs are not rendered by default.
Uh oh!
There was an error while loading. Please reload this page.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,71 @@ | ||
| /** | ||
| * @vitest-environment node | ||
| */ | ||
| import { describe, expect, it } from 'vitest' | ||
| import type { ToolCallData, ToolCallStatus } from '../../../../types' | ||
| import type { AgentGroupItem } from './agent-group' | ||
| import { isAgentGroupResolved } from './agent-group' | ||
| let toolSeq = 0 | ||
| function tool(status: ToolCallStatus): AgentGroupItem { | ||
| toolSeq += 1 | ||
| const data: ToolCallData = { | ||
| id: `tool-${toolSeq}`, | ||
| toolName: 'grep', | ||
| displayTitle: 'Searching', | ||
| status, | ||
| } | ||
| return { type: 'tool', data } | ||
| } | ||
| function text(content: string): AgentGroupItem { | ||
| return { type: 'text', content } | ||
| } | ||
| function group(items: AgentGroupItem[], isDelegating = false): AgentGroupItem { | ||
| return { | ||
| type: 'agent_group', | ||
| group: { | ||
| id: `group-${toolSeq}`, | ||
| agentName: 'deploy', | ||
| agentLabel: 'Deploy', | ||
| items, | ||
| isDelegating, | ||
| isOpen: true, | ||
| }, | ||
| } | ||
| } | ||
| describe('isAgentGroupResolved', () => { | ||
| it('is unresolved when there is no work yet', () => { | ||
| expect(isAgentGroupResolved([])).toBe(false) | ||
| expect(isAgentGroupResolved([text('thinking...')])).toBe(false) | ||
| }) | ||
| it('resolves once every own tool is terminal', () => { | ||
| expect(isAgentGroupResolved([tool('success')])).toBe(true) | ||
| expect(isAgentGroupResolved([tool('success'), tool('error')])).toBe(true) | ||
| }) | ||
| it('stays unresolved while any own tool is still executing', () => { | ||
| expect(isAgentGroupResolved([tool('success'), tool('executing')])).toBe(false) | ||
| }) | ||
| it('resolves a parent whose only work is a finished child group', () => { | ||
| expect(isAgentGroupResolved([group([tool('success')])])).toBe(true) | ||
| }) | ||
| it('stays unresolved while a nested child is still delegating', () => { | ||
| expect(isAgentGroupResolved([group([], true)])).toBe(false) | ||
| }) | ||
| it('stays unresolved while a nested child has an executing tool', () => { | ||
| expect(isAgentGroupResolved([group([tool('executing')])])).toBe(false) | ||
| }) | ||
| it('resolves deep nesting only when every descendant is terminal', () => { | ||
| expect(isAgentGroupResolved([group([group([tool('success')])])])).toBe(true) | ||
| expect(isAgentGroupResolved([group([group([tool('executing')])])])).toBe(false) | ||
| }) | ||
| }) |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,3 @@ | ||
| export type { AgentGroupItem, NestedAgentGroup } from './agent-group' | ||
| export { AgentGroup } from './agent-group' | ||
| export { AgentGroup, isAgentGroupResolved } from './agent-group' | ||
| export { CircleStop } from './tool-call-item' |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.