Skip to content

fix(files): render embedded workspace images in markdown - #5162

Merged
icecrasher321 merged 1 commit into
stagingfrom
fix/file-view-embedded
Jun 21, 2026
Merged

fix(files): render embedded workspace images in markdown#5162
icecrasher321 merged 1 commit into
stagingfrom
fix/file-view-embedded

Conversation

@icecrasher321

@icecrasher321icecrasher321 commented Jun 21, 2026

Copy link
Copy Markdown
Collaborator

Summary

Embedded refs failed to load in the mothership artifact editor: the view route issued an absolute 302 built from request.url, which behind the load balancer is the internal pod host (ip-10-0-x.ec2.internal) and is unreachable from the browser. Emit a relative Location so the browser resolves it against the public origin (matching how the Files tab fetches serve URLs).

Type of Change

  • Bug fix

Testing

Tested manually

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@icecrasher321
icecrasher321 requested a review from a team as a code ownerJune 21, 2026 03:14
@vercel

vercelBot commented Jun 21, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
ProjectDeploymentActionsUpdated (UTC)
docsSkippedSkippedJun 21, 2026 3:14am

Request Review

@greptile-apps

Copy link
Copy Markdown
Contributor

Too many files changed for review. (779 files found, 100 file limit)

@cursor

cursorBot commented Jun 21, 2026

Copy link
Copy Markdown

PR Summary

Low Risk
Documentation, gitignore, and docs-only icon/nav changes with no runtime app logic in the shown diff.

Overview
Docs and repo hygiene updates that rename the shared authz package in contributor-facing docs from @sim/workflow-authz to @sim/platform-authz, including the Vitest global mock path (@sim/platform-authz/workflowworkflowAuthzMock).

.gitignore now ignores Cursor debug logs (.cursor/debug-*.log) and editor swap files (*.swp, *.swo, *.swn).

Docs site adds Sportmonks integration surfacing: a SportmonksIcon component, registration in icon-mapping.ts, and an entry in the integrations meta.json nav list.

Note: The PR title/description references a relative Location fix on /api/files/view; that change is not present in the diff supplied for this summary.

Reviewed by Cursor Bugbot for commit fa97edb. Configure here.

@icecrasher321
icecrasher321 changed the base branch from main to stagingJune 21, 2026 03:14
@github-actionsgithub-actionsBot added the requires-mothership-merge Has a companion PR on the mothership/copilot side — merge in lockstep label Jun 21, 2026
@icecrasher321icecrasher321 changed the title Fix/file view embeddedfix(files): render embedded workspace images in markdownJun 21, 2026
@github-actionsgithub-actionsBot removed the requires-mothership-merge Has a companion PR on the mothership/copilot side — merge in lockstep label Jun 21, 2026
@icecrasher321
icecrasher321 merged commit 9a2e06e into stagingJun 21, 2026
18 checks passed
@waleedlatif1
waleedlatif1 deleted the fix/file-view-embedded branch June 21, 2026 16:44
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@icecrasher321