Skip to content

improvement(docs): flatten the academy learn/chapters panels - #5253

Merged
waleedlatif1 merged 3 commits into
stagingfrom
docs-flatten-academy-panels
Jun 28, 2026
Merged

improvement(docs): flatten the academy learn/chapters panels#5253
waleedlatif1 merged 3 commits into
stagingfrom
docs-flatten-academy-panels

Conversation

@waleedlatif1

@waleedlatif1waleedlatif1 commented Jun 28, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Flatten the academy "What you will learn" and "Chapters" panels — they were the only filled/bordered card boxes on the page, which clashes with the docs' flat design language (global.css already strips fumadocs cards/callouts to transparent/divider-based; the right-rail TOC is small, muted, borderless).
  • WhatYouWillLearn (inline): flat divider list like the FAQ, small panel label instead of a page-h2-scale title.
  • VideoChapters (right rail): borderless, mirroring the "On this page" TOC — small muted label + flat hover rows.

Follow-up to #5227 (which covered the broader design-system alignment + navbar).

Type of Change

  • Improvement

Testing

Tested manually. biome clean; token-driven, no new warnings.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@waleedlatif1
improvement(docs): flatten the academy learn/chapters panels
0534b64
The "What you will learn" and "Chapters" panels were filled, bordered
cards — the only boxed elements on the page. The docs design system is
explicitly flat: global.css strips fumadocs cards/callouts/card-grids to
transparent/divider-based, and the right-rail "On this page" TOC is small,
muted, and borderless.
- WhatYouWillLearn (inline): flat divider list like the FAQ, with a small
panel label at the app's text scale instead of a page-h2-scale title
- VideoChapters (right rail): borderless, matching the TOC — small muted
label + flat hover rows, no card chrome
@vercel

vercelBot commented Jun 28, 2026•
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
docsReadyReadyPreview, CommentJun 28, 2026 9:37pm

Request Review

@cursor

cursorBot commented Jun 28, 2026•
edited
Loading

Copy link
Copy Markdown

PR Summary

Low Risk
Presentation-only changes in docs UI components; no changes to video seek events or business logic.

Overview
Removes the filled, bordered card styling from the academy What you will learn and Chapters panels so they match the docs’ flat, divider-based layout and the On this page TOC.

WhatYouWillLearn drops the rounded surface box and large heading in favor of a small muted label and a divide-y list of takeaways (item titles stay prominent; spacing between items is divider-driven).

VideoChapters is borderless with the same muted label treatment; chapter rows lose the play icon, use baseline-aligned title/timestamp layout, and keep the existing seek/disabled behavior via academy:video-ready / academy:seek.

Reviewed by Cursor Bugbot for commit cd7f7bf. Configure here.

@greptile-apps

greptile-appsBot commented Jun 28, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR flattens the academy lesson panels to better match the docs layout.

  • Removes filled card styling from the chapter list.
  • Removes the chapter row play icon and keeps the seek button behavior.
  • Converts the takeaways panel into a muted label with divider rows.

Confidence Score: 5/5

This looks safe to merge.

  • No blocking issues found in the changed code.

Important Files Changed

FilenameOverview
apps/docs/components/ui/video-chapters.tsxFlattens the chapter rail styling while keeping the existing chapter seek event flow.
apps/docs/components/ui/what-you-will-learn.tsxChanges the takeaways panel from a filled card to a flat divider list.

Reviews (3): Last reviewed commit: "improvement(docs): drop the under-label ..." | Re-trigger Greptile

@waleedlatif1
improvement(docs): drop the repeated per-row play icon from the chapt…
9316af5
…ers list
The CirclePlay glyph repeated on every chapter row read as noise — a column
of identical icons down the rail. The "On this page" TOC this list mirrors
has no per-row icons; the timestamps already signal video chapters and the
hover highlight signals they're seekable. Rows are now text + time only.
@waleedlatif1

waleedlatif1 commented Jun 28, 2026

Copy link
Copy Markdown
CollaboratorAuthor

@greptile

@waleedlatif1

waleedlatif1 commented Jun 28, 2026

Copy link
Copy Markdown
CollaboratorAuthor

@cursor review

cursor[bot]
cursorBot reviewed Jun 28, 2026
View reviewed changes

@cursorcursorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

Reviewed by Cursor Bugbot for commit 9316af5. Configure here.

@waleedlatif1
improvement(docs): drop the under-label rule on the learn callout
cd7f7bf
A full-width rule under the small "What you will learn" label read as an
awkward heading underline and blurred into the inter-item dividers. The label
is now a quiet muted marker (matching the Chapters label and the TOC heading),
with dividers only between items — so it never competes with the bold item
titles or looks like an underlined heading.
@waleedlatif1

waleedlatif1 commented Jun 28, 2026

Copy link
Copy Markdown
CollaboratorAuthor

@greptile

@waleedlatif1

waleedlatif1 commented Jun 28, 2026

Copy link
Copy Markdown
CollaboratorAuthor

@cursor review

cursor[bot]
cursorBot reviewed Jun 28, 2026
View reviewed changes

@cursorcursorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

Reviewed by Cursor Bugbot for commit cd7f7bf. Configure here.

@waleedlatif1
waleedlatif1 merged commit 66315f1 into stagingJun 28, 2026
15 of 16 checks passed
@waleedlatif1
waleedlatif1 deleted the docs-flatten-academy-panels branch June 28, 2026 21:35
@waleedlatif1waleedlatif1 mentioned this pull request Jun 30, 2026
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cursorcursor[bot]cursor[bot] left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@waleedlatif1