Uh oh!
There was an error while loading. Please reload this page.
Conversation
The latest updates on your projects. Learn more about Vercel for GitHub. |
Greptile SummaryThis PR adds inline secret entry support to chat messages. The main changes are:
Confidence Score: 4/5The chat secret save path needs fixes before merging.
apps/sim/app/workspace/[workspaceId]/home/components/message-content/components/special-tags/special-tags.tsx
|
| Filename | Overview |
|---|---|
| apps/sim/app/workspace/[workspaceId]/home/components/message-content/components/special-tags/special-tags.tsx | Adds parsing and rendering for chat secret inputs, with new environment-save behavior and permission gates. |
Reviews (1): Last reviewed commit: "improvement(secrets): special tags impro..." | Re-trigger Greptile
| function SecretInputDisplay({ data }: { data: CredentialTagData }) { | ||
| const { workspaceId } = useParams<{ workspaceId: string }>() | ||
| const secretName = (data.name ?? '').trim() | ||
| const scope: SecretInputScope = data.scope === 'personal' ? 'personal' : 'workspace' |
There was a problem hiding this comment.
When a chat secret_input tag omits scope, this defaults the pasted credential to workspace and saves it through the shared workspace environment path. A user-provided API key entered in chat can therefore become a workspace secret instead of a user-only credential, exposing the key name and making the secret available to workspace-scoped flows.
Rule Used: API keys and other user-provided credentials shoul... (source)
Learned From
simstudioai/sim#2133
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
t# with '#' will be ignored, and an empty message aborts the commit.
Uh oh!
There was an error while loading. Please reload this page.
Summary
Add secrets input in chat
Type of Change
Testing
Manual
Checklist