Uh oh!
There was an error while loading. Please reload this page.
chore(logging): remove redis-progress-markers feature flag - #5287
Conversation
Promote the Redis progress-marker write path to permanent behavior now that the flag is fully rolled out. Block markers always write to Redis (primary), keeping the durable jsonb_set UPDATE fallback when Redis is unavailable. Removes the flag registry entry, its REDIS_PROGRESS_MARKERS env fallback, and the per-session flag resolution in the logging session.
The latest updates on your projects. Learn more about Vercel for GitHub. |
PR SummaryMedium Risk Overview
Tests drop flag mocks and scenarios for the legacy SQL-only path; remaining cases cover Redis success and SQL fallback. Reviewed by Cursor Bugbot for commit 12a2a8a. Configure here. |
Greptile SummaryThis PR makes Redis progress markers the permanent logging path. The main changes are:
Confidence Score: 5/5This looks safe to merge.
Important Files Changed
Reviews (2): Last reviewed commit: "chore(logging): drop vestigial readProgr..." | Re-trigger Greptile |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Follow-up to the redis-progress-markers flag removal. With the flag gone the completion fold always reads Redis markers, so the readProgressMarkers param (and its dead false branch) is removed end-to-end: - drop the param from completeWorkflowExecution and CompleteWorkflowExecutionParams - read progress markers unconditionally in the completion fold - delete the orphaned isFeatureEnabled mock and the flag-off / flag-throws marker tests (states the code can no longer produce)
waleedlatif1
commented
Jun 30, 2026
waleedlatif1
commented
Jun 30, 2026
@cursor review |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 12a2a8a. Configure here.
Summary
redis-progress-markersfeature flag now that it's fully rolled out, making the Redis progress-marker write path permanent behaviorjsonb_setUPDATE fallback when Redis is unavailable or the write failsREDIS_PROGRESS_MARKERSenv fallback, and the per-session flag resolution in the logging sessionreadProgressMarkersparam end-to-end (the completion fold always reads Redis markers), and delete the orphaned flag mock + flag-off/flag-throws marker tests that the code can no longer reachType of Change
Testing
vitestfor logging-session, logger, progress-markers, and feature-flags — all passingChecklist