feat(slack): reusable custom bot credentials, slack_v2 block (preview), redesigned trigger by TheodoreSpeaks · Pull Request #5323 · simstudioai/sim

TheodoreSpeaks · 2026-07-01T17:54:20Z

Summary

Redesigned Slack trigger (slack_oauth): single event per trigger block with contextual filters (source/channels/threads/emoji/name), full event catalog, interaction events (block_actions/view_submission) with optional action/callback id filter
Reusable custom Slack bots as workspace service-account credentials: set up once via a guided wizard (manifest with full permissions by default, customizable dropdown), one shared ingest URL /api/webhooks/slack/custom/{credentialId} across triggers and actions
slack_v2 block: same operations as v1, adds credential-based Custom Bot auth alongside Sim OAuth; hosts the new trigger
Preview-gated: slack_v2 + the custom-bot setup surfaces ship behind the block-visibility flag (PREVIEW_BLOCKS=slack_v2 / AppConfig); v1 + legacy slack_webhook trigger stay the GA path until v2 GAs
Reconnect for service-account credentials (Slack/Atlassian/Google): rotates secrets in place, same credential id so shares and the Slack ingest URL survive
Centralized service-account token resolution (resolveServiceAccountToken) — unknown providers fail loudly instead of silently attempting a Google JWT
Shared Slack webhook fan-out dispatcher for the native and custom ingest routes, with skip-reason diagnostics

Type of Change

New feature

Testing

Tested manually end-to-end with a custom bot (create, trigger fan-out, assistant DMs, reconnect). bun run lint:check, bun run check:api-validation:strict, bun run check:migrations origin/staging, and the Slack/credential/visibility test suites (280+ tests) pass.

Checklist

Code follows project style guidelines
Self-reviewed my changes
Tests added/updated and passing
No new warnings introduced
I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Add assistant:write, app_mentions:read, and im:history to the Slack bot OAuth scopes so the Set Assistant Status / Title / Suggested Prompts tools (assistant.threads.*) work with users' existing Slack credentials — no new app or credentials required. Restore the action_assistant trigger capability (scope assistant:write) in the manifest generator. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WpeT8J5yVCrrNQB9Hzm9uS

…e, add channel-id input

vercel · 2026-07-01T17:54:27Z

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated (UTC)
docs	Skipped		Jul 10, 2026 11:35pm

cursor · 2026-07-01T17:54:30Z

PR Summary

High Risk
Touches authentication (encrypted bot secrets, HMAC verification, OAuth token resolution), multi-tenant webhook routing by semi-public credential ids, and deploy-time team_id derivation—incorrect routing or workspace checks could cross tenants or drop events.

Overview
Introduces reusable custom Slack bot workspace credentials (slack-custom-bot): a wizard mints a stable credential id up front, verifies signing secret + bot token, and exposes one ingest URL /api/webhooks/slack/custom/{credentialId} for every trigger/action on that bot. Credential create/update paths share verifyAndBuildServiceAccountSecret; token issuance goes through resolveServiceAccountToken so Atlassian, Slack bots, and Google each dispatch explicitly and unknown providers error instead of falling through to Google JWT.

Adds slack_v2 (preview-gated like slack_v2 visibility): same Slack operations as v1 but Custom Bot picks a credential instead of pasting a raw token, and hosts the new slack_oauth trigger while v1 keeps legacy slack_webhook. Integrations UI gets Set up a custom bot, reconnect rotates secrets in place (preserving id and ingest URL), and the credential selector supports credentialKind: 'custom-bot'.

Slack trigger redesign (slack_oauth): single event type per trigger with filters (source, channels, threads, emoji, interactions, self/bot drops). Deploy maps Sim app → slack_app + routingKey = Slack team_id (from auth.test on the credential owner’s token) and custom → slack + routingKey = bot credential id. New shared routes POST /api/webhooks/slack (official app, SLACK_SIGNING_SECRET) and POST /api/webhooks/slack/custom/[credentialId] fan out via findWebhooksByRoutingKey and dispatchSlackWebhooks with shared shouldSkipSlackTriggerEvent filtering. Slack channels API treats custom-bot credentials as bot tokens; credential deletion deactivates bound Slack webhooks.

Minor: webhook path may be null for routing-key triggers; credential PATCH returns providerErrorCode for Atlassian reconnect.

^{Reviewed by Cursor Bugbot for commit 58d2851. Bugbot is set up for automated code reviews on this repo. Configure here.}

greptile-apps · 2026-07-01T17:56:35Z

Greptile Summary

This PR adds the redesigned Slack integration path and reusable custom bot credentials. The main changes are:

New slack_v2 preview block and redesigned Slack trigger.
Custom Slack bot credentials with shared ingest URLs.
Native and custom Slack webhook dispatch through shared routing logic.
Service-account reconnect and centralized token resolution.
Slack event filtering, channel matching, file handling, and credential-owner fixes.

Confidence Score: 5/5

This looks safe to merge.

No blocking issues found in the changed code.

Important Files Changed

Filename	Overview
apps/sim/lib/webhooks/providers/slack.ts	Updates Slack event filtering, channel extraction, and token-backed message/file formatting.
apps/sim/lib/webhooks/deploy.ts	Updates Slack webhook creation and recreation around native team routing and custom bot credential routing.
apps/sim/app/api/webhooks/slack/route.ts	Adds the native Slack app ingest route with team-based fan-out.
apps/sim/app/api/webhooks/slack/custom/[credentialId]/route.ts	Adds credential-specific custom bot ingest with per-bot signature verification.
apps/sim/app/api/auth/oauth/utils.ts	Centralizes service-account token resolution for Google, Atlassian, and custom Slack bot credentials.

_{Reviews (15): Last reviewed commit: "fix(slack): 409 on custom-bot name colli..." | Re-trigger Greptile}

# Conflicts: # apps/sim/blocks/blocks/slack.ts # apps/sim/lib/webhooks/deploy.ts # packages/db/migrations/meta/0253_snapshot.json # packages/db/migrations/meta/_journal.json # scripts/check-api-validation-contracts.ts

TheodoreSpeaks · 2026-07-01T18:10:01Z

@greptile review

…oken for reaction text + file downloads

TheodoreSpeaks · 2026-07-01T18:21:12Z

@greptile review — addressed the three findings: (1) unmapped/unselected events now drop instead of bypassing the Operations filter, (2) formatInput resolves the OAuth bot token for slack_app webhooks so reaction-message text works, (3) re-added the includeFiles toggle + token resolution so native file downloads work.

…token via credential owner not execution actor

TheodoreSpeaks · 2026-07-01T18:32:22Z

@greptile review — addressed both: empty operation selection now fires nothing (no match-all), and the OAuth token is resolved via the credential owner (not the execution actor) so it works in shared workspaces.

…r channel picker over stale manual ids

…ull event catalog

TheodoreSpeaks · 2026-07-07T00:26:47Z

@greptile review

# Conflicts: # apps/sim/lib/webhooks/deploy.ts # packages/db/migrations/meta/0258_snapshot.json # packages/db/migrations/meta/_journal.json

- nullable webhook.path coalesced at correlation/payload/tiktok boundaries - slack dispatch delegates to staging's dispatchResolvedWebhookTarget (shared preprocess/deployment/filter/enqueue lifecycle), keeping the skip-reason diagnostics; route tests reworked around that seam - api-validation route baseline 924 -> 926

TheodoreSpeaks · 2026-07-10T22:36:09Z

@greptile review

…oks on routing transitions - a bot credential id is semi-public (embedded in Slack Request URLs), so the custom deploy branch now rejects credentials outside the workflow's workspace - needsRecreation also compares path/routingKey, so a row from an older routing model can't survive redeploy as a stale delivery surface

TheodoreSpeaks · 2026-07-10T22:42:41Z

@greptile review

…rning the existing credential The service-account dedupe matches on displayName, which defaults to the Slack team name — shared by every bot in that workspace. A second unnamed bot create returned the first credential as success, orphaning the new id already pasted into the Slack Request URL. Same-id replays stay idempotent; different-id collisions now fail loudly so the wizard prompts for a distinct name.

TheodoreSpeaks · 2026-07-10T23:03:03Z

@greptile review

…e/description edits - PUT credential route now returns the Atlassian provider code (providerErrorCode -> code) so reconnect failures map to specific token/domain messages, matching create - Google/Atlassian reconnect send + seed displayName/description (parity with Slack); edits are no longer silently discarded, and empty fields don't clobber existing values

cursor

Cursor Bugbot has reviewed your changes using default effort and found 2 potential issues.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit 470e3c5. Configure here.}

…ks on reconnect - the setup wizard now requires a bot name (canAdvance), so the credential name, manifest app name, and uniqueness key all use the user's choice instead of the shared Slack team-name fallback that collided for a second bot in one workspace - reconnect that changes the bot user id (recreated Slack app) now updates the bot_user_id cached in each bound webhook's providerConfig, so reaction self-drop keeps working instead of letting the bot's own reactions re-enter

TheodoreSpeaksand others added 4 commits June 30, 2026 19:59

Add slack trigger
ec1eb62

fix channel picker in slack trigger
5a36f48

improvement(slack-trigger): reorder app type, gate account to sim mod…
7efbfd3
…e, add channel-id input

cursorBot reviewed Jul 1, 2026
View reviewed changes

Comment threadapps/sim/app/api/webhooks/slack/route.ts Outdated

greptile-appsBot reviewed Jul 1, 2026
View reviewed changes

Comment threadapps/sim/app/api/webhooks/slack/route.ts Outdated
Comment threadapps/sim/lib/webhooks/deploy.ts
Comment threadapps/sim/triggers/slack/oauth.ts Outdated

vercelBotdeployed to Preview July 1, 2026 17:59 View deployment

Merge remote-tracking branch 'origin/staging' into improve/slack
4886d1d
# Conflicts: # apps/sim/blocks/blocks/slack.ts # apps/sim/lib/webhooks/deploy.ts # packages/db/migrations/meta/0253_snapshot.json # packages/db/migrations/meta/_journal.json # scripts/check-api-validation-contracts.ts

vercelBotdeployed to Preview July 1, 2026 18:14 View deployment

fix(slack-trigger): drop unmapped events from filter, resolve oauth t…
71beec4
…oken for reaction text + file downloads

vercelBottemporarily deployed to Preview July 1, 2026 18:21 Inactive

greptile-appsBot reviewed Jul 1, 2026
View reviewed changes

Comment threadapps/sim/app/api/webhooks/slack/route.ts Outdated
Comment threadapps/sim/lib/webhooks/providers/slack.ts Outdated

cursorBot reviewed Jul 1, 2026
View reviewed changes

Comment threadapps/sim/app/api/webhooks/slack/route.ts Outdated

fix(slack-trigger): empty operation selection fires nothing; resolve …
a0e723b
…token via credential owner not execution actor

vercelBottemporarily deployed to Preview July 1, 2026 18:32 Inactive

cursorBot reviewed Jul 1, 2026
View reviewed changes

Comment threadapps/sim/app/api/webhooks/slack/route.ts Outdated

greptile-appsBot reviewed Jul 1, 2026
View reviewed changes

Comment threadapps/sim/app/api/webhooks/slack/route.ts Outdated

fix(slack-trigger): ignore message edit/delete/system subtypes; prefe…
310061d
…r channel picker over stale manual ids

vercelBottemporarily deployed to Preview July 1, 2026 18:45 Inactive

cursorBot reviewed Jul 1, 2026
View reviewed changes

Comment threadapps/sim/lib/webhooks/deploy.ts Outdated
Comment threadapps/sim/app/api/webhooks/slack/route.ts Outdated

feat(slack-trigger): single-event model with contextual filters and f…
65c1415
…ull event catalog

vercelBottemporarily deployed to Preview July 7, 2026 00:26 Inactive

cursorBot reviewed Jul 7, 2026
View reviewed changes

Comment threadapps/sim/lib/webhooks/deploy.ts Outdated

TheodoreSpeaks added 2 commits July 10, 2026 15:26

Merge remote-tracking branch 'origin/staging' into improve/slack
26217bf
# Conflicts: # apps/sim/lib/webhooks/deploy.ts # packages/db/migrations/meta/0258_snapshot.json # packages/db/migrations/meta/_journal.json

TheodoreSpeaks changed the title ~~feat(slack): native OAuth trigger, reusable custom bots, slack_v2 block~~feat(slack): reusable custom bot credentials, slack_v2 block (preview), redesigned triggerJul 10, 2026

cursorBot reviewed Jul 10, 2026
View reviewed changes

Comment threadapps/sim/lib/webhooks/deploy.ts

greptile-appsBot reviewed Jul 10, 2026
View reviewed changes

Comment threadapps/sim/lib/webhooks/deploy.ts

vercelBotdeployed to Preview July 10, 2026 22:40 View deployment

vercelBottemporarily deployed to Preview July 10, 2026 22:42 Inactive

greptile-appsBot reviewed Jul 10, 2026
View reviewed changes

Comment threadapps/sim/lib/webhooks/providers/slack.ts

test(slack): pin fail-closed behavior for empty/missing event selection
9146a33

vercelBottemporarily deployed to Preview July 10, 2026 22:47 Inactive

cursorBot reviewed Jul 10, 2026
View reviewed changes

Comment threadapps/sim/app/api/credentials/route.ts

vercelBottemporarily deployed to Preview July 10, 2026 23:03 Inactive

cursorBot reviewed Jul 10, 2026
View reviewed changes

Comment threadapps/sim/app/api/credentials/[id]/route.ts
Comment thread...eId]/integrations/components/connect-service-account-modal/connect-service-account-modal.tsx

vercelBottemporarily deployed to Preview July 10, 2026 23:15 Inactive

cursorBot reviewed Jul 10, 2026
View reviewed changes

Comment threadapps/sim/lib/credentials/service-account-secret.ts
Comment threadapps/sim/lib/webhooks/providers/slack.ts

vercelBottemporarily deployed to Preview July 10, 2026 23:35 Inactive

TheodoreSpeaks merged commit f4d47ed into stagingJul 10, 2026
17 checks passed

TheodoreSpeaks deleted the improve/slack branch July 10, 2026 23:43

waleedlatif1 mentioned this pull request Jul 11, 2026
v0.7.29: GLM, ui and ux improvements #5567
Merged

TheodoreSpeaks mentioned this pull request Jul 13, 2026
fix(slack): stop requesting unapproved OAuth scopes that break connect #5631
Merged
6 tasks

TheodoreSpeaks mentioned this pull request Jul 23, 2026
feat(slack): native Sim app trigger mode via the preview-gated slack_v2 block #5892
Merged

This was referenced Aug 6, 2026
fix(unsubscribe): unsubscribe page missing suspense boundary #683
Merged
upstream-sync: merge simstudioai/sim main into feat/github-merge-agent (2026-08-06) arenadeveloper02/p2-sim#683
Closed

Uh oh!

Conversation

TheodoreSpeaks commented Jul 1, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Type of Change

Testing

Checklist

Uh oh!

vercelBot commented Jul 1, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cursorBot commented Jul 1, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Summary

Uh oh!

Uh oh!

greptile-appsBot commented Jul 1, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Greptile Summary

Confidence Score: 5/5

Important Files Changed

Uh oh!

Uh oh!

Uh oh!

Uh oh!

TheodoreSpeaks commented Jul 1, 2026

Uh oh!

TheodoreSpeaks commented Jul 1, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

TheodoreSpeaks commented Jul 1, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

TheodoreSpeaks commented Jul 7, 2026

Uh oh!

Uh oh!

TheodoreSpeaks commented Jul 10, 2026

Uh oh!

Uh oh!

Uh oh!

TheodoreSpeaks commented Jul 10, 2026

Uh oh!

Uh oh!

Uh oh!

TheodoreSpeaks commented Jul 10, 2026

Uh oh!

Uh oh!

Uh oh!

cursorBot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

TheodoreSpeaks commented Jul 1, 2026•
edited
Loading

vercelBot commented Jul 1, 2026•
edited
Loading

cursorBot commented Jul 1, 2026•
edited
Loading

greptile-appsBot commented Jul 1, 2026•
edited
Loading