Skip to content

fix(landing): inset careers row hover, drop trusted-by section, gate contact submit#5380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
waleedlatif1 merged 1 commit into from
Jul 2, 2026
Merged

fix(landing): inset careers row hover, drop trusted-by section, gate contact submit #5380

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions apps/sim/app/(landing)/careers/careers.tsx
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -9,7 +9,6 @@ import {
JobGroups,
} from '@/app/(landing)/careers/components/job-board'
import { careersSearchParamsCache } from '@/app/(landing)/careers/search-params'
import { TrustedBy } from '@/app/(landing)/components/trusted-by'

interface CareersProps {
searchParams: Promise<SearchParams>
Expand DownExpand Up@@ -87,8 +86,6 @@ export default async function Careers({ searchParams }: CareersProps) {
>
<JobBoard postings={postings} />
</Suspense>

<TrustedBy className='pt-6' />
</section>
</main>
)
Expand Down
4 changes: 2 additions & 2 deletions apps/sim/app/(landing)/careers/components/job-board/job-groups.tsx
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -83,8 +83,8 @@ function JobRow({ posting }: JobRowProps) {
target='_blank'
rel='noopener noreferrer'
className={cn(
'group flex items-center justify-between gap-6 border-[var(--border)] border-t py-5',
'transition-colors hover:bg-[var(--surface-hover)]'
'-mx-3 group flex items-center justify-between gap-6 rounded-lg border-[var(--border)]',
'border-t px-3 py-5 transition-colors hover:bg-[var(--surface-hover)]'
)}
>
<div className='flex min-w-0 flex-col gap-1.5'>
Expand Down
10 changes: 9 additions & 1 deletion apps/sim/app/(landing)/contact/components/contact-form/contact-form.tsx
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -12,6 +12,7 @@ import {
} from '@/lib/api/contracts/contact'
import { flattenFieldErrors } from '@/lib/api/contracts/primitives'
import { getEnv } from '@/lib/core/config/env'
import { quickValidateEmail } from '@/lib/messaging/email/validation'
import { captureClientEvent } from '@/lib/posthog/client'
import { useSubmitContact } from '@/hooks/queries/contact'

Expand DownExpand Up@@ -175,6 +176,13 @@ export function ContactForm() {
)
}

const canSubmit =
quickValidateEmail(form.email.trim()).isValid &&
form.name.trim().length > 0 &&
form.topic.length > 0 &&
form.subject.trim().length > 0 &&
form.message.trim().length > 0
Comment thread
waleedlatif1 marked this conversation as resolved.

const isBusy = contactMutation.isPending || isSubmitting

const submitError = contactMutation.isError
Expand DownExpand Up@@ -336,7 +344,7 @@ export function ContactForm() {
variant='primary'
flush
fullWidth
disabled={isBusy}
disabled={isBusy || !canSubmit}
className='mt-1 justify-center [&>span]:flex-none'
>
{isBusy ? 'Sending…' : 'Send message'}
Expand Down
Loading