Uh oh!
There was an error while loading. Please reload this page.
fix(canvas): raw tooltip shows up when hovering block params - #5589
Conversation
…p on block params Hovering a truncated subblock value or block name on the canvas popped the browser's raw native tooltip with the full untruncated content (including raw code). Replace the `title` attribute with the cursor-following styled Tooltip, shown only when the text is actually clipped.
The latest updates on your projects. Learn more about Vercel for GitHub.
|
PR SummaryLow Risk Overview Introduces shared Reviewed by Cursor Bugbot for commit 6e06e6c. Configure here. |
Greptile SummaryThis PR replaces raw browser tooltips on workflow canvas text with styled overflow-only tooltips. The main changes are:
Confidence Score: 5/5This looks safe to merge.
Important Files Changed
Reviews (2): Last reviewed commit: "fix(canvas): drop unused ResizeObserver ..." | Re-trigger Greptile |
Uh oh!
There was an error while loading. Please reload this page.
useFloatingTooltip's canShow already receives the hovered element, so measuring overflow via useIsOverflowing was redundant — every canvas row was paying for a ResizeObserver and resize listener it never used.
waleedlatif1
commented
Jul 11, 2026
waleedlatif1
commented
Jul 11, 2026
@cursor review |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 6e06e6c. Configure here.
Uh oh!
There was an error while loading. Please reload this page.
Summary
sub-block-row-view.tsxandworkflow-block-view.tsxused a nativetitleattribute on truncated spans instead of the styled cursor-following TooltipOverflowSpancomponent (built on the existing@sim/emcnfloating-tooltip primitives) that shows the styled tooltip only when the text is actually clipped, and swapped both call sites to use itType of Change
Testing
bun run type-checkandbun run lint:checkpass for theworkflow-rendererpackagebun run check:api-validationand the monorepo boundary check passtitleattribute is emitted, and the styled floating tooltip renders the full value only on hover when the text overflowsChecklist