Uh oh!
There was an error while loading. Please reload this page.
feat(triggers): service-account credentials in the hubspot trigger - #5693
Conversation
The latest updates on your projects. Learn more about Vercel for GitHub.
|
PR SummaryMedium Risk Overview Credential create API now returns 409 Docs on the HubSpot service-account page mention the CRM Trigger and why a non-expiring token suits polling. Reviewed by Cursor Bugbot for commit e212cda. Bugbot is set up for automated code reviews on this repo. Configure here. |
Greptile SummaryThis PR adds service-account credentials to the HubSpot polling trigger. The main changes are:
Confidence Score: 5/5This looks safe to merge.
Important Files Changed
Reviews (4): Last reviewed commit: "feat(triggers): service-account credenti..." | Re-trigger Greptile |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
TheodoreSpeaks
commented
Jul 15, 2026
TheodoreSpeaks
commented
Jul 15, 2026
@cursor review |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit e244a7a. Configure here.
Uh oh!
There was an error while loading. Please reload this page.
TheodoreSpeaks
commented
Jul 15, 2026
TheodoreSpeaks
commented
Jul 15, 2026
@cursor review |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit a523223. Configure here.
…token-SA name-collision 409
a523223 to
e212cdaCompareTheodoreSpeaks
commented
Jul 15, 2026
TheodoreSpeaks
commented
Jul 15, 2026
@cursor review |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit e212cda. Configure here.
Summary
resolveOAuthCredential) resolvesservice_accountcredentials viaresolveServiceAccountToken, and a newallowServiceAccountssubblock flag opts the trigger's credential picker into listing them (enabled on the HubSpot poller)duplicate_display_nameon token service-account create collisions (all 12 providers): previously a name match fell through to the existing-credential path and silently dropped the submitted token; the token modal already maps this code to a friendly messageType of Change
Testing
Tested manually.
lint,tsc, andcheck:api-validation:strictpass.Checklist