Uh oh!
There was an error while loading. Please reload this page.
feat(pii): regex-only block-output redaction + drop GLiNER/GPU image - #5697
Conversation
The latest updates on your projects. Learn more about Vercel for GitHub. |
PR SummaryMedium Risk Overview The Presidio service adds a regex-only analyze fast path that skips the spaCy NLP pass when the request lists only non-NER entities and has no positive GLiNER/GPU support is removed: Reviewed by Cursor Bugbot for commit 47ca743. Bugbot is set up for automated code reviews on this repo. Configure here. |
TheodoreSpeaks
commented
Jul 15, 2026
@greptile review |
Greptile SummaryThis PR makes block-output PII redaction regex-only and simplifies the PII service. The main changes are:
Confidence Score: 5/5This looks safe to merge.
Important Files Changed
Reviews (4): Last reviewed commit: "fix(pii): include ORGANIZATION in app-si..." | Re-trigger Greptile |
Uh oh!
There was an error while loading. Please reload this page.
Greptile SummaryThis PR makes block-output PII redaction regex-only and removes the GLiNER deployment path. The main changes are:
Confidence Score: 4/5Thresholded Presidio requests can miss context-sensitive PII and need fixes before merging.
apps/pii/server.py
|
| Filename | Overview |
|---|---|
| apps/pii/server.py | Adds regex-only analysis helpers and globally disables spaCy pipes, creating false-negative paths for thresholded requests. |
| apps/sim/lib/guardrails/pii-entities.ts | Defines the shared NER entity set and filters block-output choices and hydrated policies. |
| apps/sim/lib/api/contracts/primitives.ts | Strips NER entities from block-output policies and disables stages left empty. |
| apps/sim/lib/billing/retention.ts | Enforces regex-only block-output policies during runtime resolution. |
| apps/sim/ee/data-retention/components/data-retention-settings.tsx | Restricts block-output selections and sanitizes policies before saving. |
| docker/pii.Dockerfile | Removes GLiNER, Torch, CUDA, development-test dependencies, and deleted source files. |
| helm/sim/templates/deployment-pii.yaml | Removes obsolete engine and device wiring while retaining generic environment variables. |
Reviews (2): Last reviewed commit: "feat(pii): restrict block-output redacti..." | Re-trigger Greptile
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
TheodoreSpeaks
commented
Jul 15, 2026
TheodoreSpeaks
commented
Jul 15, 2026
@cursor review |
Uh oh!
There was an error while loading. Please reload this page.
TheodoreSpeaks
commented
Jul 15, 2026
TheodoreSpeaks
commented
Jul 15, 2026
@cursor review |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 47ca743. Configure here.
Summary
NlpArtifactsto bypass the spaCy NER pass entirely — the per-leaf cost that made bulk block-output redaction slow.redact_batchlogsnlp=skip|full.docker/pii.Dockerfile, deleteengines.py/requirements-gliner/bench+tests, restoreserver.pyto a self-contained CPU spaCy service (keeps the NER-only pipe-disable ~2x win + the logging-emit fix), and drop the Helmpii.engine/pii.devicewiring.Type of Change
Testing
check:api-validation:strictclean;py_compileserver.py;helm lint+helm unittest(10/10) pass.nlp=skipand run dramatically faster than a NER (nlp=full) request.Checklist