Skip to content

improvement(ship): pre-flight regenerate artifacts + parallel audit suite - #5927

Merged
waleedlatif1 merged 4 commits into
stagingfrom
ship-preflight-scripts
Jul 24, 2026
Merged

improvement(ship): pre-flight regenerate artifacts + parallel audit suite#5927
waleedlatif1 merged 4 commits into
stagingfrom
ship-preflight-scripts

Conversation

@waleedlatif1

@waleedlatif1waleedlatif1 commented Jul 24, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Expand /ship step 6 into two phases so generated files never drift into a CI failure (the agent-stream-docs drift we just hit on the Opus 5 PR)
  • Phase A — regenerate every committed artifact in parallel (agent-stream-docs:generate, skills:sync, and all the contract *:generate scripts); idempotent, staged into the commit
  • Phase B — run lint then the full audit suite CI's Lint and Test job enforces (check:boundaries, check:api-validation:strict, check:utils, check:zustand-v5, check:react-query, check:client-boundary, check:bare-icons, check:icon-paths, check:realtime-prune, skills:check, agent-stream-docs:check) in parallel, aborting ship on any failure
  • Regenerated the .claude/commands/ship.md + .cursor/commands/ship.md projections

Type of Change

  • Improvement (tooling / developer workflow)

Testing

  • Dogfooded on this change: skills:sync regenerated the ship projections, skills:check passes, bun run lint clean

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@waleedlatif1
improvement(ship): pre-flight regenerate artifacts + parallel audit s…
e66baa9
…uite
Add a two-phase pre-ship step: (A) regenerate every committed artifact
(agent-stream-docs, skills, contract syncs) in parallel so generated files
never drift into a CI failure, then (B) run lint plus the full audit suite
CI's Lint and Test job enforces, in parallel, aborting ship on any failure.
Regenerate the ship command projections.
@vercel

vercelBot commented Jul 24, 2026•
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
docsReadyReadyPreview, CommentJul 24, 2026 6:01pm

Request Review

@cursor

cursorBot commented Jul 24, 2026•
edited
Loading

Copy link
Copy Markdown

PR Summary

Low Risk
Documentation-only changes to the ship workflow; no application runtime, auth, or data-path changes.

Overview
Expands /ship step 6 from lint plus check:api-validation:strict into a two-phase pre-ship gate so committed generated files and CI audits are exercised before commit.

Phase A runs agent-stream-docs:generate and skills:sync in parallel (disjoint outputs), collects per-job exit codes (because bare wait hides failures), and requires staging any regenerated files in step 7. It explicitly does not blanket-run mship:generate, its constituent contract generators, or generate:pi-model-catalog on every ship—those are only for PRs that touch their inputs and need external sources.

Phase B runs bun run lint first (mutating, must fail the step on error), then the rest of the Lint and Test read-only audits in parallel (check:boundaries, check:api-validation:strict, check:utils, check:zustand-v5, check:react-query, check:client-boundary, check:bare-icons, check:icon-paths, check:realtime-prune, skills:check, agent-stream-docs:check) with the same exit-code aggregation pattern.

The same step-6 wording is applied in .agents/skills/ship/SKILL.md and the synced .claude/commands/ship.md / .cursor/commands/ship.md projections.

Reviewed by Cursor Bugbot for commit fcab4a2. Configure here.

cursor[bot]
cursorBot reviewed Jul 24, 2026
View reviewed changes
Comment thread.agents/skills/ship/SKILL.md
Comment thread.agents/skills/ship/SKILL.md
@greptile-apps

greptile-appsBot commented Jul 24, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

Greptile Summary

The PR strengthens the /ship workflow:

  • Regenerates committed agent-stream documentation and command projections before staging.
  • Runs lint before parallelizing the read-only CI audit suite.
  • Explicitly propagates generator, lint, and audit failures to prevent commit and push.
  • Synchronizes the Claude and Cursor command projections with the canonical ship skill.

Confidence Score: 5/5

The PR appears safe to merge.

No blocking failure remains.

Important Files Changed

FilenameOverview
.agents/skills/ship/SKILL.mdDefines the two-phase regeneration and audit workflow and now explicitly exits nonzero when any check fails.
.claude/commands/ship.mdSynchronizes the Claude command projection with the updated canonical ship workflow.
.cursor/commands/ship.mdSynchronizes the Cursor command projection with the updated canonical ship workflow.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[Run ship] --> B[Phase A: regenerate artifacts in parallel]
B --> C{All generators passed?}
C -- No --> X[Abort ship]
C -- Yes --> D[Run lint]
D --> E{Lint passed?}
E -- No --> X
E -- Yes --> F[Phase B: run audits in parallel]
F --> G{All audits passed?}
G -- No --> X
G -- Yes --> H[Stage generated and authored changes]
H --> I[Commit and push]
Loading

Reviews (4): Last reviewed commit: "fix(ship): gate lint exit in Phase B pre..." | Re-trigger Greptile

@waleedlatif1
fix(ship): scope Phase A to in-repo generators + propagate failures
b1c173a
Cursor review: (1) mship:generate is an umbrella over the 9 contract
generators and biome-formats the shared generated dir, so running it
alongside its constituents races/corrupts; it also reads an external
copilot-contract source that ENOENTs in a bare worktree. (2) bare wait
swallowed generator exit codes. Narrow Phase A to the always-in-repo
generators (agent-stream-docs, skills) and collect each job's exit
status in both phases; document domain generators as on-demand only.
@waleedlatif1

waleedlatif1 commented Jul 24, 2026

Copy link
Copy Markdown
CollaboratorAuthor

@greptile

@waleedlatif1

waleedlatif1 commented Jul 24, 2026

Copy link
Copy Markdown
CollaboratorAuthor

@cursor review

cursor[bot]
cursorBot reviewed Jul 24, 2026
View reviewed changes
Comment thread.agents/skills/ship/SKILL.md Outdated
@waleedlatif1
fix(ship): make pre-flight status checks exit non-zero on failure
f6cb728
Cursor/Greptile: grep && echo ❌ || echo ✅ always exits 0, so a failed
generator/audit didn't actually gate ship (regressed the sequential
bun-run checks whose non-zero exit agents rely on). Replace both Phase A
and Phase B aggregations with an if-grep that exits 1 on any failure.
@waleedlatif1

waleedlatif1 commented Jul 24, 2026

Copy link
Copy Markdown
CollaboratorAuthor

@greptile

@waleedlatif1

waleedlatif1 commented Jul 24, 2026

Copy link
Copy Markdown
CollaboratorAuthor

@cursor review

cursor[bot]
cursorBot reviewed Jul 24, 2026
View reviewed changes
Comment thread.agents/skills/ship/SKILL.md
@waleedlatif1
fix(ship): gate lint exit in Phase B pre-flight
fcab4a2
Cursor: bare bun run lint before the audit grep meant a non-zero lint
was ignored — if audits then passed, the block exited 0 and ship
continued. Gate lint with || { echo …; exit 1; } so an unfixable lint
error aborts before the audits run.
@waleedlatif1

waleedlatif1 commented Jul 24, 2026

Copy link
Copy Markdown
CollaboratorAuthor

@greptile

@waleedlatif1

waleedlatif1 commented Jul 24, 2026

Copy link
Copy Markdown
CollaboratorAuthor

@cursor review

cursor[bot]
cursorBot reviewed Jul 24, 2026
View reviewed changes

@cursorcursorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

Reviewed by Cursor Bugbot for commit fcab4a2. Configure here.

@waleedlatif1
waleedlatif1 merged commit 6105376 into stagingJul 24, 2026
5 of 6 checks passed
@waleedlatif1
waleedlatif1 deleted the ship-preflight-scripts branch July 24, 2026 18:01
@waleedlatif1waleedlatif1 mentioned this pull request Jul 24, 2026
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cursorcursor[bot]cursor[bot] left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@waleedlatif1