Skip to content

feat(realtime): Yjs relay server for collaborative document editing [4/N]#5941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
waleedlatif1 merged 9 commits into from
Jul 24, 2026
Merged

feat(realtime): Yjs relay server for collaborative document editing [4/N] #5941

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
ece7c9e
feat(realtime): Yjs relay server for collaborative document editing […
waleedlatif1 Jul 24, 2026
a16ad4f
fix(realtime): harden file-doc relay per review
waleedlatif1 Jul 24, 2026
1bf1a1b
fix(realtime): enforce client-id uniqueness + clear ghost carets
waleedlatif1 Jul 24, 2026
56af964
fix(realtime): key client-id ownership by user to fix reconnect lockout
waleedlatif1 Jul 24, 2026
ee4aed7
fix(realtime): check client-id ownership before clearing prior caret
waleedlatif1 Jul 24, 2026
a161659
fix(realtime): guard concurrent-JOIN race in file-doc relay
waleedlatif1 Jul 24, 2026
4913c41
improvement(realtime): seed deadline re-election + audit polish
waleedlatif1 Jul 24, 2026
050d348
cleanup(realtime): dedupe idle-room teardown + skip awareness state d…
waleedlatif1 Jul 24, 2026
5a47caa
fix(realtime): stop LEAVE from aborting an unrelated in-flight join
waleedlatif1 Jul 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions apps/realtime/package.json
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -33,9 +33,12 @@
"@sim/workflow-types": "workspace:*",
"@socket.io/redis-adapter": "8.3.0",
"drizzle-orm": "^0.45.2",
"lib0": "0.2.117",
"postgres": "^3.4.5",
"redis": "5.10.0",
"socket.io": "^4.8.1",
"y-protocols": "1.0.7",
"yjs": "13.6.31",
"zod": "4.3.6"
},
"devDependencies": {
Expand Down
4 changes: 4 additions & 0 deletions apps/realtime/src/handlers/connection.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
import { createLogger } from '@sim/logger'
import { parseRoomName, type RoomRef, roomName } from '@sim/realtime-protocol/rooms'
import { cleanupFileDocForSocket } from '@/handlers/file-doc'
import { cleanupPendingSubblocksForSocket } from '@/handlers/subblocks'
import { cleanupPendingVariablesForSocket } from '@/handlers/variables'
import type { AuthenticatedSocket } from '@/middleware/auth'
Expand DownExpand Up@@ -31,6 +32,9 @@ export function setupConnectionHandlers(socket: AuthenticatedSocket, roomManager
// Clean up pending debounce entries for this socket to prevent memory leaks
cleanupPendingSubblocksForSocket(socket.id)
cleanupPendingVariablesForSocket(socket.id)
// Clear the socket's collaborative-document awareness (removes its caret for
// everyone else) and drop the room if it was the last editor.
cleanupFileDocForSocket(socket.id, roomManager.io)

// A socket may occupy multiple rooms (one per type). Remove it from every
// room the manager knows about.
Expand Down
Loading