Skip to content

fix(db): index large-value workflow_id FKs so workflow deletes don't seq-scan#6136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TheodoreSpeaks merged 1 commit into from
Jul 31, 2026
Merged

fix(db): index large-value workflow_id FKs so workflow deletes don't seq-scan #6136

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions packages/db/migrations/0278_charming_imperial_guard.sql
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,14 @@
-- Both tables carry `workflow_id ... ON DELETE SET NULL` (migration 0212) with no index leading
-- on that column. Postgres implements SET NULL as an AFTER ROW referential trigger running
-- `UPDATE ... SET workflow_id = NULL WHERE workflow_id = $1` once per deleted parent row, so
-- every `DELETE FROM workflow` sequentially scans both tables per workflow — enough to blow the
-- statement timeout once the soft-delete retention job starts hard-deleting archived workflows.
-- Both indexes exist to make that trigger index-driven.
--
-- Replay-safety: this file is only CONCURRENTLY index builds below an embedded COMMIT, so a
-- failure replays the whole file — both statements are idempotent.
COMMIT;--> statement-breakpoint
SET lock_timeout = 0;--> statement-breakpoint
CREATE INDEX CONCURRENTLY IF NOT EXISTS "execution_large_value_references_workflow_id_idx" ON "execution_large_value_references" USING btree ("workflow_id");--> statement-breakpoint
CREATE INDEX CONCURRENTLY IF NOT EXISTS "execution_large_values_workflow_id_idx" ON "execution_large_values" USING btree ("workflow_id");--> statement-breakpoint
Comment on lines +12 to +13

@greptile-appsgreptile-appsBotJul 31, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1Invalid indexes survive migration replay

When either concurrent build fails after creating its catalog entry, the replayed IF NOT EXISTS statement skips the resulting INVALID index, allowing the migration to complete while workflow deletions continue sequentially scanning the corresponding large-value table.

Knowledge Base Used:Database schema and migrations (packages/db)

SET lock_timeout = '5s';
Loading
Loading