fix(search): restore cmd+k autofocus on the search input

[waleedlatif1]

Summary

• Cmd+K opened the search palette without focusing the input, so you had to click it before typing
• Regressed in feat(browser, terminal): implement browser driver, password manager, terminal features #6196 (5ab5f2c7e): the dialog's visibility gate moved to visuallyOpen (open && nativeSurfaceReady), but the focus effect stayed on a separate focusReady gate that is just open off the desktop app
• nativeSurfaceReady starts false and only flips inside a useLayoutEffect, so the focus effect ran in the commit where the panel still carried invisible — .focus() on a visibility: hidden element is a silent no-op, and nothing re-focused it afterwards
• Fix is one gate: focus off visuallyOpen, so it runs on the first commit where the panel is actually visible. Desktop (atomic browser panel occlusion) already waited for that same signal, so its behavior is unchanged

Type of Change

• Bug fix

Testing

Typecheck and lint pass. Not yet verified in a running browser — needs a manual Cmd+K check before merge.

No unit test: the failure depends on visibility: hidden making an element unfocusable, which jsdom does not model (it applies no Tailwind CSS), so a test here would pass with or without the fix.

Checklist

• Code follows project style guidelines
• Self-reviewed my changes
• Tests added/updated and passing
• No new warnings introduced
• I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated (UTC)
docs	Skipped		Aug 6, 2026 10:44pm

[cursor]

PR Summary

Low Risk
Small UI focus-timing fix in the search modal with no auth, data, or API changes.

Overview
Fixes Cmd+K opening the search palette without focusing the input (regression from splitting visibility on visuallyOpen while focus still gated on focusReady / open).

The focus useEffect now runs when visuallyOpen is true—the same signal used to drop invisible on the dialog—so .focus() happens after the surface is actually visible. The separate focusReady gate is removed. Desktop paths that already waited on visuallyOpen are unchanged.

^{Reviewed by Cursor Bugbot for commit 0556297. Configure here.}

[greptile-apps]

Greptile Summary

This PR restores Cmd+K autofocus by delaying the search-input focus effect until the dialog is visibly open.

• Removes the separate platform-dependent focusReady gate.
• Uses visuallyOpen for both the focus guard and effect dependency.
• Documents why focusing while the dialog carries visibility: hidden is ineffective.

Confidence Score: 5/5

The PR appears safe to merge, with the autofocus effect now aligned to the dialog’s visible lifecycle.

The focus effect waits for visuallyOpen, avoids attempting focus while the input is hidden, and remains guarded during close and native-surface preparation states.

Important Files Changed

Filename	Overview
apps/sim/app/workspace/[workspaceId]/w/components/sidebar/components/search-modal/search-modal.tsx	Aligns input focus with the modal’s visible state, without introducing an actionable lifecycle or repository-rule issue.

_{Reviews (1): Last reviewed commit: "fix(search): restore cmd+k autofocus on ..." | Re-trigger Greptile}