fix(chat): render HEIC attachments and restyle composer file chips by waleedlatif1 · Pull Request #6361 · simstudioai/sim

waleedlatif1 · 2026-08-07T01:45:54Z

Summary

Composer previewed every attachment via URL.createObjectURL of the raw bytes. No browser decodes HEVC-coded HEIF, so a HEIC rendered a broken glyph — and since the upload-completion handler never replaced that blob URL, it stayed broken even once a server derivative existed.
HEIC/HEIF now skip the blob and pick up the serve URL (preview=1) once the upload lands, so the JPEG derivative renders. Other images keep their blob URL — no extra round trip for a thumbnail the browser can already draw.
Added an onError fallback: if the image still fails (transcode unavailable, 401/409), the type icon shows instead of a broken glyph.
Documents now render as labelled cards — icon badge, filename, type — instead of a 9px extension caption. Media keeps the thumbnail. Both are 48px so a mixed row shares a baseline.
Fixed a blob-URL leak: the unmount cleanup had [] deps closing over the first render's empty array, so it revoked nothing, ever.

Type of Change

Bug fix

Testing

tsc --noEmit, lint, check:api-validation clean. 1013 tests pass. Four new tests on the chip; verified the two behavioral ones fail without their fix.

Not yet verified in a browser — pill proportions against the 48px tiles and the overlapping remove badge need a visual check.

Checklist

Code follows project style guidelines
Self-reviewed my changes
Tests added/updated and passing
No new warnings introduced
I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

The composer previewed every attachment through URL.createObjectURL of the raw bytes. No browser decodes HEVC-coded HEIF, so a HEIC showed a broken glyph, and the upload-completion handler never replaced that blob URL — so it stayed broken even once a derivative was available. - Skip the blob for HEIC/HEIF and pick up the serve URL (preview=1) once the upload lands, so the server derivative renders. - Fall back to the type icon if the image still fails to decode. - Documents render as labelled cards (icon, name, type) instead of a 9px extension caption; media keeps a thumbnail. - Fix a blob-URL leak: the unmount cleanup closed over the first render's empty array and revoked nothing.

vercel · 2026-08-07T01:45:58Z

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated (UTC)
docs	Skipped		Aug 7, 2026 1:57am

cursor · 2026-08-07T01:46:05Z

PR Summary

Medium Risk
Touches upload preview lifecycle and blob URL revocation in a shared hook; UI-only risk is mostly layout/styling in the composer, but incorrect preview URLs could still affect attachment display after upload.

Overview
Fixes composer attachment previews for HEIC/HEIF and refreshes how file chips look in the chat composer.

Preview pipeline: Attachments no longer always use URL.createObjectURL on raw bytes. HEIC/HEIF skip blob previews and, after upload, use the mothership serve URL (preview=1) for a JPEG derivative. Other images still use blob URLs when the browser can decode them. Upload completion now sets previewUrl via getMothershipAttachmentPreviewUrl when there was no local preview. use-file-attachments fixes blob URL leaks by revoking only blob: URLs, using a ref for unmount/remove/clear/restore cleanup, and keeping state updaters pure under StrictMode.

Chip UI:AttachedFilesList splits into AttachedFileChip with two 48px-tall shapes—media thumbnails vs document cards (icon, filename, extension)—stable HEIC layout before preview exists, and onError on images to show the type icon when decode fails. Surfaces, remove badge, and upload overlay styling are updated for the composer shell.

Tests: Four Vitest/jsdom cases cover document vs image rendering, HEIC thumbnail shape without preview, and preview error fallback.

^{Reviewed by Cursor Bugbot for commit 710767e. Configure here.}

greptile-apps · 2026-08-07T01:49:01Z

Greptile Summary

The PR adds server-rendered previews for HEIC/HEIF attachments, improves attachment chip presentation and fallback behavior, and corrects blob URL cleanup.

Uses server-generated image derivatives for formats browsers cannot decode locally.
Restyles media and document attachments as aligned 48px chips.
Revokes locally created object URLs during removal, replacement, clearing, failed uploads, and unmount.
Adds focused rendering and image-error fallback tests.

Confidence Score: 5/5

The PR appears safe to merge.

No blocking failure remains.

Important Files Changed

Filename	Overview
apps/sim/app/workspace/[workspaceId]/home/components/user-input/components/attached-files-list/attached-files-list.test.tsx	Adds focused chip-rendering tests and now uses the required absolute aliases, fully resolving the previous import finding.
apps/sim/app/workspace/[workspaceId]/home/components/user-input/components/attached-files-list/attached-files-list.tsx	Introduces distinct media and document chip layouts with image-error fallback and accessible removal controls.
apps/sim/app/workspace/[workspaceId]/w/[workflowId]/components/panel/components/copilot/components/user-input/hooks/use-file-attachments.ts	Routes HEIC/HEIF previews through server derivatives and centralizes safe blob URL cleanup across attachment lifecycle operations.

_{Reviews (3): Last reviewed commit: "chore(chat): use the absolute alias for ..." | Re-trigger Greptile}

The composer is --white in light and --surface-4 in dark. The chip reused chipFilledFillTokens (--surface-5 / dark:--surface-4), which assumes a page background, so in dark mode the chip fill matched its own container exactly and only the border showed. Same for the remove badge, which sits on the shell and was 5/255 from it. - Chip fills --surface-5 in both themes and hover steps away from the shell in each theme's 'raised' direction. - Remove badge uses --surface-6, readable on white and on --surface-4. - Cap the document card at min(220px,100%) so a long filename truncates on a narrow viewport instead of overflowing the composer.

waleedlatif1 · 2026-08-07T01:50:52Z

@greptile

waleedlatif1 · 2026-08-07T01:50:53Z

@cursor review

cursor

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

^{Reviewed by Cursor Bugbot for commit a016489. Configure here.}

waleedlatif1 · 2026-08-07T01:58:02Z

@greptile

waleedlatif1 · 2026-08-07T01:58:03Z

@cursor review

cursor

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

^{Reviewed by Cursor Bugbot for commit 710767e. Configure here.}

vercelBottemporarily deployed to Preview August 7, 2026 01:45 Inactive

greptile-appsBot reviewed Aug 7, 2026
View reviewed changes

Comment thread...ceId]/home/components/user-input/components/attached-files-list/attached-files-list.test.tsx Outdated

vercelBottemporarily deployed to Preview August 7, 2026 01:50 Inactive

cursorBot reviewed Aug 7, 2026
View reviewed changes

chore(chat): use the absolute alias for the chip test import
710767e

vercelBottemporarily deployed to Preview August 7, 2026 01:57 Inactive

cursorBot reviewed Aug 7, 2026
View reviewed changes

waleedlatif1 merged commit 8694f55 into stagingAug 7, 2026
24 checks passed

waleedlatif1 deleted the fix/composer-attachment-chips branch August 7, 2026 02:00

waleedlatif1 mentioned this pull request Aug 7, 2026
v0.7.62: file handling, mothership async runs, heic support, file hardening, general ui improvements #6366
Merged

Navigation Menu

Uh oh!

fix(chat): render HEIC attachments and restyle composer file chips - #6361

fix(chat): render HEIC attachments and restyle composer file chips#6361
waleedlatif1 merged 3 commits into
stagingfrom
fix/composer-attachment-chips

waleedlatif1 commented Aug 7, 2026

Uh oh!

vercelBot commented Aug 7, 2026•
edited
Loading

Uh oh!

cursorBot commented Aug 7, 2026•
edited
Loading

Uh oh!

greptile-appsBot commented Aug 7, 2026•
edited
Loading

Important Files Changed

Uh oh!

Uh oh!

waleedlatif1 commented Aug 7, 2026

Uh oh!

waleedlatif1 commented Aug 7, 2026

Uh oh!

cursorBot left a comment

Uh oh!

waleedlatif1 commented Aug 7, 2026

Uh oh!

waleedlatif1 commented Aug 7, 2026

Uh oh!

cursorBot left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

waleedlatif1 commented Aug 7, 2026

Summary

Type of Change

Testing

Checklist

Uh oh!

vercelBot commented Aug 7, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cursorBot commented Aug 7, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Summary

Uh oh!

greptile-appsBot commented Aug 7, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Greptile Summary

Confidence Score: 5/5

Important Files Changed

Uh oh!

Uh oh!

waleedlatif1 commented Aug 7, 2026

Uh oh!

waleedlatif1 commented Aug 7, 2026

Uh oh!

cursorBot left a comment

Choose a reason for hiding this comment

Uh oh!

waleedlatif1 commented Aug 7, 2026

Uh oh!

waleedlatif1 commented Aug 7, 2026

Uh oh!

cursorBot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

vercelBot commented Aug 7, 2026•
edited
Loading

cursorBot commented Aug 7, 2026•
edited
Loading

greptile-appsBot commented Aug 7, 2026•
edited
Loading