Uh oh!
There was an error while loading. Please reload this page.
improvement(forking): widen the fork mapping target picker and make it searchable - #6381
Conversation
The latest updates on your projects. Learn more about Vercel for GitHub. |
PR SummaryLow Risk Overview The truncated-candidates note is updated to say search only filters targets already shown in the list (not the full candidate set behind Reviewed by Cursor Bugbot for commit f3158e1. Configure here. |
Greptile SummaryThe PR improves the fork-sync mapping target picker and corrects the truncation guidance.
Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains.
|
| Filename | Overview |
|---|---|
| apps/sim/ee/workspace-forking/components/fork-sync/fork-sync-view.tsx | Widens the mapping picker, enables filtering over supplied candidates, and accurately clarifies the existing candidate-cap limitation. |
Reviews (2): Last reviewed commit: "fix(forking): stop the truncated-candida..." | Re-trigger Greptile
Uh oh!
There was an error while loading. Please reload this page.
…hat cannot reach past the cap
527a243 to
f3158e1Comparewaleedlatif1
commented
Aug 7, 2026
waleedlatif1
commented
Aug 7, 2026
@cursor review |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit f3158e1. Configure here.
Summary
SLACK_PUX_SANDBOX_KB_…— two same-prefixed keys were indistinguishable in the listsearchablefor that picker so you can type to filter targets instead of scrollingCANDIDATE_LIMIT, but there was no search box to do it inNo emcn changes —
ChipComboboxis already the searchable picker (ChipDropdownis the no-search one), andsearchableis an existing prop used at 55 other call sites. The width constant is shared with the webhook trigger-URL rows so both stay one aligned column.Trade-off: the label column goes 464px → 384px, so long names clip slightly sooner on the left. Right-side ambiguity was the reported bug.
Type of Change
Testing
Tested manually —
tsc --noEmit, biome, and the 502 workspace-forking tests pass. Note those tests cover the fork-sync logic layer only; nothing rendersfork-sync-view.tsx, so the visual change is unverified by tests.Checklist