Uh oh!
There was an error while loading. Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork 3.8k
feat(search): page-aware cmd+k palette with ask-Sim mode#6518
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
Changes from all commits
04147f7b840a3acd23af8ed4ea7cd078e8281716ff45357cb3e67769fc881bfa4625ab1ce85ca109178300dceb4ecb6ade9139781160d50016a6787c1bd985852f70008128f1a77ce2a62971be5a8ac0dc4b2728b0ecf229b82ef4693e245b39bb9761a25599ad2d36File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -36,6 +36,7 @@ import { | ||
| } from '@/app/workspace/[workspaceId]/components/folders' | ||
| import { PresenceAvatars } from '@/app/workspace/[workspaceId]/components/presence/presence-avatars' | ||
| import { LogDetails } from '@/app/workspace/[workspaceId]/logs/components' | ||
| import { useRegisterGlobalCommands } from '@/app/workspace/[workspaceId]/providers/global-commands-provider' | ||
| import { useUserPermissionsContext } from '@/app/workspace/[workspaceId]/providers/workspace-permissions-provider' | ||
| import { ImportCsvDialog } from '@/app/workspace/[workspaceId]/tables/components/import-csv-dialog' | ||
| import { ImportProgressMenu } from '@/app/workspace/[workspaceId]/tables/components/import-progress-menu' | ||
| @@ -1068,6 +1069,34 @@ export function Table({ | ||
| } | ||
| }, [tableData, workspaceId]) | ||
| useRegisterGlobalCommands(() => [ | ||
| { | ||
| id: 'table-new-column', | ||
| handler: () => { | ||
| if (!userPermissions.canEdit) return | ||
| if (tableDataRef.current?.locks.schemaLocked) { | ||
| showBlockedToast('add-column') | ||
| return | ||
| } | ||
| handleAddColumnOfType('string') | ||
| }, | ||
| }, | ||
| { | ||
| id: 'table-export-csv', | ||
| handler: () => { | ||
| if (!tableDataRef.current?.rowCount) return | ||
| void handleExportCsv() | ||
| }, | ||
| }, | ||
| { | ||
| id: 'table-import-csv', | ||
| handler: () => { | ||
| if (!userPermissions.canEdit || tableDataRef.current?.locks.insertLocked) return | ||
| onRequestImportCsv() | ||
| }, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Silent locked CSV importMedium Severity
Additional Locations (1)Reviewed by Cursor Bugbot for commit b39bb97. Configure here. | ||
| }, | ||
| ]) | ||
| const columnOptions = useMemo<ColumnOption[]>( | ||
| () => | ||
| columns.map((col) => ({ | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -46,6 +46,7 @@ import { | ||
| useFolderNavigation, | ||
| useFolderRowDragDrop, | ||
| } from '@/app/workspace/[workspaceId]/components/folders' | ||
| import { useRegisterGlobalCommands } from '@/app/workspace/[workspaceId]/providers/global-commands-provider' | ||
| import { useUserPermissionsContext } from '@/app/workspace/[workspaceId]/providers/workspace-permissions-provider' | ||
| import { | ||
| ImportCsvDialog, | ||
| @@ -1033,6 +1034,17 @@ export function Tables() { | ||
| } | ||
| }, [workspaceId, folders, currentFolderId, createFolderAsync, setSearchTerm, startFolderRename]) | ||
| useRegisterGlobalCommands(() => [ | ||
| { id: 'tables-new-table', handler: () => void handleCreateTable() }, | ||
| { id: 'tables-new-folder', handler: () => void handleCreateFolder() }, | ||
| { | ||
| id: 'tables-import-csv', | ||
| handler: () => { | ||
| if (!uploading) csvInputRef.current?.click() | ||
| }, | ||
| }, | ||
| ]) | ||
j15z marked this conversation as resolved.
Uh oh!There was an error while loading. Please reload this page. | ||
| const headerActions: ResourceAction[] = useMemo( | ||
| () => [ | ||
| { | ||
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.


There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Silent empty CSV export
Low Severity
table-export-csvis always offered on table detail, but the handler no-ops whenrowCountis 0. The header Export control is disabled for empty tables, so the palette path gives no indication why nothing happened—the same class of silent failure the deploy action was later fixed to toast for.Additional Locations (1)
apps/sim/app/workspace/[workspaceId]/w/components/sidebar/components/search-modal/search-modal.tsx#L369-L378Reviewed by Cursor Bugbot for commit b39bb97. Configure here.