Uh oh!
There was an error while loading. Please reload this page.
improvement(audits): skip the sql-date-binding parse for files without drizzle-orm - #6554
Conversation
The latest updates on your projects. Learn more about Vercel for GitHub.
|
PR SummaryCursor Bugbot is generating a summary for commit 38d5b01. Configure here. |
…t drizzle-orm check:sql-date-binding Babel-parsed all 13,941 source files in apps, packages, and scripts. A violation can only come from an `sql` tag resolved through a `drizzle-orm` import, and both the static and dynamic resolvers match the specifier as a string literal, so a file that never names the module cannot produce one. Only ~590 files do. Skipping the parse for the other 92% of bytes takes the audit from ~4.5s to ~0.8s and drops it out of the four slowest audits, taking check:audits from 6.0s to 5.3s wall and 38.0s to 32.9s serial. Output is unchanged.
38d5b01 to
0ee302bComparewaleedlatif1
commented
Aug 11, 2026
waleedlatif1
commented
Aug 11, 2026
@cursor review |
Greptile SummaryThis PR accelerates the SQL Date-binding audit by parsing only source files whose raw text names
Confidence Score: 5/5The PR appears safe to merge because the new prefilter retains every currently reachable Drizzle SQL-binding analysis path. The raw substring check includes all existing
|
| Filename | Overview |
|---|---|
| scripts/check-sql-date-binding.ts | Adds a conservative source-text prefilter before Babel parsing; no actionable defect was established for the repository’s current sources. |
Reviews (2): Last reviewed commit: "improvement(audits): skip the sql-date-b..." | Re-trigger Greptile
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 0ee302b. Configure here.
Summary
check:sql-date-bindingBabel-parsed all 13,941 source files underapps,packages, andscripts. A violation can only come from ansqltag resolved through adrizzle-ormimport, and both the static (collectSqlBindings) and dynamic (isDrizzleImportCall) resolvers match the specifier as a string literal — so a file that never names the module cannot bind the tag and cannot violate.check:auditsgoes 6.0s → 5.3s wall, 38.0s → 32.9s serial.Type of Change
Testing
Tested manually:
✓ 13941 files bind every sql-template Date through a column encoder, warm timings 4.38s/4.63s → 0.82s/0.76s.sql\... ${aDate}`in a file importingsqlfromdrizzle-orm`) and confirmed it is still reported with exit 1.bun run check:auditsandbunx biome checkpass.Checklist