Skip to content

fix(tables): preserve group auto-run semantics - #6579

Merged
TheodoreSpeaks merged 1 commit into
stagingfrom
fix/table-group-auto-run-dispatch
Aug 12, 2026
Merged

fix(tables): preserve group auto-run semantics#6579
TheodoreSpeaks merged 1 commit into
stagingfrom
fix/table-group-auto-run-dispatch

Conversation

@TheodoreSpeaks

Copy link
Copy Markdown
Collaborator

Summary

  • use non-manual new dispatch semantics for group auto-run
  • prevent auto-run from cancelling active work or clearing completed cells

Type of Change

  • Bug fix

Testing

  • 23 focused table group application and route tests
  • Sim app typecheck
  • Full lint
  • All 25 repository audits

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercelBot commented Aug 12, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
ProjectDeploymentActionsUpdated (UTC)
docsSkippedSkippedAug 12, 2026 2:00am

Request Review

@cursor

cursorBot commented Aug 12, 2026

Copy link
Copy Markdown

PR Summary

Medium Risk
Changes workflow dispatch semantics for table group auto-run, which affects which rows execute and whether existing cell state is preserved. Scope is small and moves toward safer non-manual behavior.

Overview
Fixes group auto-run so it no longer behaves like a manual full rerun.

dispatchGroupAutoRun now calls runWorkflowColumn with mode: 'new' and isManualRun: false, so enabling auto-run only fills never-attempted rows and does not cancel in-flight work or clear completed cells. Adds a focused test covering those dispatch args.

Reviewed by Cursor Bugbot for commit 13ce40f. Bugbot is set up for automated code reviews on this repo. Configure here.

@greptile-apps

Copy link
Copy Markdown
Contributor

Greptile Summary

The PR changes workflow-group auto-run dispatches to use non-manual new semantics, preserving existing cell results and active work.

  • Runs only group cells that have not previously been attempted.
  • Prevents automatic dispatches from cancelling active executions or clearing completed cells.
  • Adds a focused application-level test for the dispatch parameters.

Confidence Score: 5/5

The PR appears safe to merge with no actionable correctness or security issues identified.

The changed dispatch parameters align with the existing workflow-column eligibility, clearing, and cancellation behavior, while the added test covers the intended application call.

Important Files Changed

FilenameOverview
apps/sim/lib/table/application/groups.tsChanges group auto-run dispatches from manual all-row reruns to non-manual new-row processing, consistent with the underlying eligibility and cancellation contracts.
apps/sim/lib/table/application/groups.test.tsAdds focused coverage asserting that group creation dispatches auto-run with mode new and isManualRun: false.

Reviews (1): Last reviewed commit: "fix(tables): preserve group auto-run sem..." | Re-trigger Greptile

@TheodoreSpeaks
TheodoreSpeaks merged commit 5e1862e into stagingAug 12, 2026
30 checks passed
@TheodoreSpeaks
TheodoreSpeaks deleted the fix/table-group-auto-run-dispatch branch August 12, 2026 02:46
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@TheodoreSpeaks