Uh oh!
There was an error while loading. Please reload this page.
improvement(updates): validate update path and fix native mac help - #6580
Merged
Conversation
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
Greptile SummaryThe PR adds native macOS Help documentation search and routes the desktop View > Search command to the workspace search modal.
Confidence Score: 5/5The PR appears safe to merge with no concrete blocking or independently actionable non-blocking defects identified. The native provider is platform-gated, packaged at its resolved runtime path, validates remote URLs, cancels superseded work, and is cleaned up idempotently; the new search command is consistently represented across the main process, preload transport, shared type, and workspace listener.
|
| Filename | Overview |
|---|---|
| apps/desktop/native/help-search.mm | Implements a bounded, cancellable AppKit Help search provider with endpoint and result URL validation. |
| apps/desktop/scripts/build.ts | Compiles the native provider as a universal macOS Node-API bundle while leaving non-macOS builds portable. |
| apps/desktop/src/main/help-search.ts | Loads, validates, installs, and safely uninstalls the optional native bridge. |
| apps/desktop/src/main/index.ts | Integrates Help provider lifecycle management and routes the search menu command to the main renderer. |
| apps/desktop/src/main/menu.ts | Adds View > Search with the Mod+K accelerator and delegates activation through injected menu dependencies. |
| apps/sim/app/workspace/[workspaceId]/components/workspace-chrome/workspace-chrome.tsx | Handles the new desktop command by mirroring the existing search-modal toggle behavior. |
| packages/desktop-bridge/src/index.ts | Extends the shared desktop command contract with the additive open-search command. |
Sequence Diagram
sequenceDiagram
participant User
participant Menu as Electron Menu
participant Main as Desktop Main Process
participant Bridge as Preload Bridge
participant Workspace as WorkspaceChrome
participant Modal as Search Modal Store
participant Help as Native Help Provider
participant Docs as docs.sim.ai
User->>Menu: Press Mod+K
Menu->>Main: openSearch()
Main->>Bridge: desktop:command(open-search)
Bridge->>Workspace: onCommand(open-search)
Workspace->>Modal: Toggle search modal
User->>Help: Search macOS Help
Help->>Docs: GET /api/search
Docs-->>Help: Documentation results
Help-->>User: Native Help items
Reviews (1): Last reviewed commit: "Desktop update check" | Re-trigger Greptile
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix native mac help
Type of Change
Testing
Manual
Checklist