Skip to content

fix(logs): restore narrow v1 detail query - #6588

Merged
TheodoreSpeaks merged 1 commit into
stagingfrom
fix/cancel-workflow
Aug 12, 2026
Merged

fix(logs): restore narrow v1 detail query#6588
TheodoreSpeaks merged 1 commit into
stagingfrom
fix/cancel-workflow

Conversation

@TheodoreSpeaks

Copy link
Copy Markdown
Collaborator

Summary

  • Restore the route-specific v1 log detail query
  • Avoid loading unused snapshot, deployment, pause, and owner data

Type of Change

  • Bug fix

Testing

  • bun run lint
  • bun run apps/sim/scripts/check-block-registry.ts origin/staging
  • bun run check:audits

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercelBot commented Aug 12, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
ProjectDeploymentActionsUpdated (UTC)
docsSkippedSkippedAug 12, 2026 2:50am

Request Review

@cursor

cursorBot commented Aug 12, 2026

Copy link
Copy Markdown

PR Summary

Low Risk
Scoped query change in a single API route that keeps the same response shape and access checks; mainly a performance fix.

Overview
Restores a narrow, route-specific query for GET /api/v1/logs/[id] instead of using shared getPublicWorkflowLog.

The inline select joins only workflowExecutionLogs and workflow, avoiding unused snapshot, deployment, pause, and owner joins that the shared helper loads. Response shaping and workspace access checks stay the same.

Reviewed by Cursor Bugbot for commit 3ca8818. Bugbot is set up for automated code reviews on this repo. Configure here.

@greptile-apps

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR restores a route-specific query for v1 log details while preserving the endpoint’s existing authorization and response behavior.

  • Selects only the execution-log and workflow fields used by the detail response.
  • Removes joins and fields associated with snapshots, deployments, paused executions, and workflow owners.

Confidence Score: 5/5

The PR appears safe to merge with no actionable correctness or security regressions identified.

The narrowed query preserves every field used by the response, handles deleted workflows through the existing nullable join behavior, and retains the authentication and workspace authorization gates.

Important Files Changed

FilenameOverview
apps/sim/app/api/v1/logs/[id]/route.tsReplaces the broad shared log query with a narrow projection while retaining all fields consumed by the route and the existing workspace-access check.

Reviews (1): Last reviewed commit: "fix(logs): restore narrow v1 detail quer..." | Re-trigger Greptile

@TheodoreSpeaks
TheodoreSpeaks merged commit 766526b into stagingAug 12, 2026
30 checks passed
@waleedlatif1
waleedlatif1 deleted the fix/cancel-workflow branch August 12, 2026 02:57
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@TheodoreSpeaks