Skip to content

fix(tables): prevent legacy group auto-run dispatch - #6595

Merged
TheodoreSpeaks merged 1 commit into
stagingfrom
fix/table-cascade
Aug 12, 2026
Merged

fix(tables): prevent legacy group auto-run dispatch#6595
TheodoreSpeaks merged 1 commit into
stagingfrom
fix/table-cascade

Conversation

@TheodoreSpeaks

Copy link
Copy Markdown
Collaborator

Summary

  • only dispatch table group auto-run on an explicit false-to-true transition
  • add regression coverage for legacy groups without a persisted autoRun value

Type of Change

  • Bug fix

Testing

  • targeted Vitest suite
  • TypeScript type-check
  • lint and full audit suite

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercelBot commented Aug 12, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
ProjectDeploymentActionsUpdated (UTC)
docsSkippedSkippedAug 12, 2026 4:27am

Request Review

@cursor

cursorBot commented Aug 12, 2026

Copy link
Copy Markdown

PR Summary

Medium Risk
Changes when background workflow auto-runs are dispatched for table groups, which can affect unintended job execution. The fix is narrowly scoped and more conservative than the previous behavior.

Overview
Prevents unintended auto-run when updating legacy table groups that lack a persisted autoRun field.

updateTableGroupUseCase and updateWorkflowTableGroup now set startAutoRun only on an explicit false → true transition (previousGroup.autoRun === false), instead of treating any non-true prior value (including undefined) as a newly enabled toggle.

Adds regression tests covering both update paths for legacy enabled groups.

Reviewed by Cursor Bugbot for commit 6bd9537. Bugbot is set up for automated code reviews on this repo. Configure here.

@greptile-apps

Copy link
Copy Markdown
Contributor

Greptile Summary

The PR narrows table-group auto-run dispatch to explicit false-to-true transitions so saving legacy groups with no persisted autoRun value does not start execution.

  • Updates both generic and workflow-specific group update commands.
  • Adds regression tests for legacy groups whose autoRun property is absent.

Confidence Score: 4/5

The PR appears safe to merge, with only a non-blocking gap in coverage for explicitly enabling a disabled group.

The implementation consistently prevents legacy undefined-to-true saves from dispatching while retaining explicit false-to-true behavior, but the added tests exercise only the suppression side of that contract.

Files Needing Attention: apps/sim/lib/table/application/groups.test.ts

Important Files Changed

FilenameOverview
apps/sim/lib/table/application/groups.tsCorrectly restricts both update paths to explicit false-to-true auto-run transitions.
apps/sim/lib/table/application/groups.test.tsCovers legacy absent-value suppression but omits positive coverage preserving explicit false-to-true dispatch.

Reviews (1): Last reviewed commit: "fix(tables): prevent legacy group auto-r..." | Re-trigger Greptile

Comment threadapps/sim/lib/table/application/groups.test.ts
@TheodoreSpeaks
TheodoreSpeaks merged commit 9923faf into stagingAug 12, 2026
30 checks passed
@TheodoreSpeaks
TheodoreSpeaks deleted the fix/table-cascade branch August 12, 2026 04:32
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@TheodoreSpeaks