Uh oh!
There was an error while loading. Please reload this page.
fix(tables): prevent legacy group auto-run dispatch - #6595
Conversation
The latest updates on your projects. Learn more about Vercel for GitHub. |
PR SummaryMedium Risk Overview
Adds regression tests covering both update paths for legacy enabled groups. Reviewed by Cursor Bugbot for commit 6bd9537. Bugbot is set up for automated code reviews on this repo. Configure here. |
Greptile SummaryThe PR narrows table-group auto-run dispatch to explicit false-to-true transitions so saving legacy groups with no persisted
Confidence Score: 4/5The PR appears safe to merge, with only a non-blocking gap in coverage for explicitly enabling a disabled group. The implementation consistently prevents legacy undefined-to-true saves from dispatching while retaining explicit false-to-true behavior, but the added tests exercise only the suppression side of that contract. Files Needing Attention: apps/sim/lib/table/application/groups.test.ts
|
| Filename | Overview |
|---|---|
| apps/sim/lib/table/application/groups.ts | Correctly restricts both update paths to explicit false-to-true auto-run transitions. |
| apps/sim/lib/table/application/groups.test.ts | Covers legacy absent-value suppression but omits positive coverage preserving explicit false-to-true dispatch. |
Reviews (1): Last reviewed commit: "fix(tables): prevent legacy group auto-r..." | Re-trigger Greptile
Uh oh!
There was an error while loading. Please reload this page.
Summary
Type of Change
Testing
Checklist