Uh oh!
There was an error while loading. Please reload this page.
fix(tables): tolerate row deletion during run cancellation - #6600
Conversation
The latest updates on your projects. Learn more about Vercel for GitHub. |
PR SummaryMedium Risk Overview Cancellation writes now swallow Tombstone inserts similarly ignore Postgres FK violations on the row FK ( Adds regression coverage for both deletion races. Reviewed by Cursor Bugbot for commit f008e38. Bugbot is set up for automated code reviews on this repo. Configure here. |
Greptile SummaryThe PR makes workflow-group cancellation tolerate rows deleted concurrently while preserving fail-fast behavior for unrelated database errors.
Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains.
|
| Filename | Overview |
|---|---|
| apps/sim/lib/table/workflow-columns.ts | Adds narrowly scoped handling for wrapped row-not-found errors and row-FK tombstone failures without suppressing unrelated write errors. |
| apps/sim/lib/table/workflow-columns.test.ts | Adds focused coverage for direct and transaction-wrapped deletion races plus fail-fast behavior for unrelated failures. |
Reviews (2): Last reviewed commit: "fix(tables): unwrap row deletion errors" | Re-trigger Greptile
Uh oh!
There was an error while loading. Please reload this page.
592f37f to
f008e38CompareTheodoreSpeaks
commented
Aug 12, 2026
TheodoreSpeaks
commented
Aug 12, 2026
@cursor review |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit f008e38. Configure here.
Summary
Type of Change
Testing
bun run test lib/table/workflow-columns.test.tsbun run type-checkbunx biome lint apps/sim/lib/table/workflow-columns.ts apps/sim/lib/table/workflow-columns.test.tsbun run check:api-validationChecklist