Uh oh!
There was an error while loading. Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork 3.8k
improvement(imports): changed relative to absolute imports#681
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
Changes from all commits
File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||||
|---|---|---|---|---|---|---|---|---|---|---|
| @@ -1,8 +1,8 @@ | ||||||||||
| import { readFile } from 'fs/promises' | ||||||||||
| // @ts-ignore | ||||||||||
| import * as pdfParseLib from 'pdf-parse/lib/pdf-parse.js' | ||||||||||
Comment on lines
2
to
3
Contributor There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. style: Consider adding explanation in the @ts-ignore comment about why it's needed for pdf-parse
Suggested change
| ||||||||||
| import type { FileParseResult, FileParser } from '@/lib/file-parsers/types' | ||||||||||
| import { createLogger } from '@/lib/logs/console-logger' | ||||||||||
| import type { FileParseResult, FileParser } from './types' | ||||||||||
| const logger = createLogger('PdfParser') | ||||||||||
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
style: consider also using absolute import for EmailType to maintain consistency with other imports