Uh oh!
There was an error while loading. Please reload this page.
chore: require Node 22 LTS and drop the WASIp2 fallback - #122
Merged
Conversation
- raise engines to >=22.0.0 in skilld and skilld-protocol - remove the unused ws dependency from skilld-harness - remove the unpublished WASIp2 fallback: skilld-cli-wasm32-wasi, skilld-wasi crate, wit-bindgen, host WIT file, and its parity scripts
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The v3 native rewrite left two loose ends: engines still allowed Node 18 while CI and the other packages already require Node 22 LTS, and the WASIp2 fallback never shipped.
Changes
>=18.18.0/>=18->>=22.0.0inskilldandskilld-protocol(matchesskilld-harness)wsfromskilld-harnessand the catalog (never imported; Node 22 has native WebSocket)packages/cli-wasm32-wasiand@bytecodealliance/preview2-shimcatalog entrycrates/skilld-wasi,wit-bindgenworkspace dep,wit/skilld-host.witscripts/v3-rust/build-component.sh,scripts/v3-rust/test-parity.sh,tests/fixtures/v3-rust/wasip2-no-go.jsonVerification
pnpm install(lockfile updated)cargo check --workspaceandcargo clippy --workspace --all-targets -- -D warningscleanpnpm test:js: 30/30 passtsc --noEmitin protocol + harnessAgent-generated.