Uh oh!
There was an error while loading. Please reload this page.
SK-2519: extract hard coded strings to constants and update linting r… - #272
Conversation
✅ Gitleaks Findings: No secrets detected. Safe to proceed! |
Semgrep Findings: Issues with Error level severity are found (Error is Highest severity in Semgrep), Please resolve the issues before merging. |
…ests for request bodies
…and update request ID format in HttpUtility
| import com.skyflow.utils.Constants; | ||
| @SuppressWarnings("checkstyle:MultipleStringLiterals") |
There was a problem hiding this comment.
Why did we add SuppressWarnings annotation here ? What warnings are we suppressing ?
There was a problem hiding this comment.
as the file constains strings, and checkstyle linter will catch them, so added SuppressWarnings to avoid it catching
| <consoleOutput>true</consoleOutput> | ||
| <excludes>**/generated/**</excludes> | ||
| <excludes>**/generated/**,**/logs/**</excludes> |
There was a problem hiding this comment.
Why are we excluding logs ?
There was a problem hiding this comment.
as log constains strings, and checkstyle linter will catch them, so excluded logs to avoid it catching
…-values-in-java-v2-sdk' of https://github.com/skyflowapi/skyflow-java into aadarsh-st/SK-2521-fixed-bug-bash-issue
…bash-issue aadarsh-st/SK-2521-Enhance content-type handling and add validation t…
Uh oh!
There was an error while loading. Please reload this page.
Why:
Following the Node SDK linting audit and refactor, this ticket focuses on applying the same linting standards and best practices across Java SDK v2.
The goal is to ensure consistent use of constants over hardcoded values across Java SDK v2, improving maintainability and readability.
Goal:
Update linting rules to discourage hardcoded literals where constants should be used.
Refactor existing code to replace hardcoded values with well-defined constants.