Skip to content

SK-3026 add tokens key in insert - #399

Merged
skyflow-bharti merged 8 commits into
flowvault-release/26.8.1from
flowvault-release/26.8.1.1
Aug 3, 2026
Merged

SK-3026 add tokens key in insert#399
skyflow-bharti merged 8 commits into
flowvault-release/26.8.1from
flowvault-release/26.8.1.1

Conversation

@skyflow-bharti

Copy link
Copy Markdown
Collaborator

Start with a concise summary of the PR. The first three sections are required. The questions present in each section is there to help you guide you what to add. They are meant to be overwritten by your comments.

Why

  • Why are you making the change?
  • What is the underlying issue that you are trying to case, in case of fix?
  • Why is it needed by the feature you are working on?
  • What is the intent behind making the change?

Goal

  • What is the intended outcome?
  • What part of the feature should start working?
  • What are the non-goals or will be covered in future PR?

Testing

  • How was the code tested?
  • If you haven't written unit tests, why?
  • What more testing is needed? Do you intend to manually test it after deployment?
  • Do you have any concerns if this changed is released to prod?

Tech debt

  • Is the PR adding to tech debt in any way?
  • Are you addressing some Tech debt in this PR?
  • If both the above are false, feel free to remove this section.

@codecov

codecovBot commented Aug 3, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.30%. Comparing base (53bcb86) to head (c784ff3).

Additional details and impacted files
@@ Coverage Diff @@## flowvault-release/26.8.1 #399 +/- ##
==============================================================
+ Coverage 91.27% 91.30% +0.02% 
Complexity 454 454 ==============================================================
Files 157 157 Lines 6372 6392 +20 Branches 829 834 +5 ==============================================================
+ Hits 5816 5836 +20 
Misses 364 364 Partials 192 192 
FlagCoverage Δ
common88.38% <ø> (ø)
flowvault88.65% <100.00%> (+0.10%)⬆️
skyvault94.72% <ø> (ø)
unittests-flowvault89.67% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

ComponentsCoverage Δ
Module: common88.38% <ø> (ø)
Module: skyvault94.72% <ø> (ø)
Module: flowvault88.65% <100.00%> (+0.10%)⬆️
Service Account86.69% <ø> (ø)
Vault Data91.42% <ø> (ø)
Vault Tokens99.03% <ø> (ø)
Vault Connection100.00% <ø> (ø)
Vault Controller85.31% <ø> (ø)
Detect100.00% <ø> (ø)
Audit100.00% <ø> (ø)
BIN Lookup100.00% <ø> (ø)
Config96.26% <ø> (ø)
Utils89.21% <100.00%> (+0.11%)⬆️
Errors100.00% <ø> (ø)
Enums100.00% <ø> (ø)
Logs95.32% <ø> (ø)
Files with missing linesCoverage Δ
...ava/com/skyflow/utils/validations/Validations.java92.83% <100.00%> (+0.49%)⬆️

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 53bcb86...c784ff3. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@skyflow-bhartiskyflow-bharti changed the title SK-3026 remove unused tokens key in insertSK-3026 add tokens key in insertAug 3, 2026
@skyflow-bharti
skyflow-bharti merged commit c731182 into flowvault-release/26.8.1Aug 3, 2026
30 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@skyflow-bharti@saileshwar-skyflow@Devesh-Skyflow