SK-3002 fix javadoc links blocking the flowvault public release

[Devesh-Skyflow]

Problem

flowvault/v1.0.0 — the first real public release — failed at Publish package (run 30826092656):

flowvault/src/main/java/com/skyflow/vault/data/BulkTokenizeRequestRecord.java:9: error: reference not found
* bulk request has somewhere to grow, mirroring the {@link BulkInsertRecord} / {@link InsertRecord}

Neither type exists. The real names are BulkInsertRequestRecord and InsertRequestRecord — the doc comment dropped Request from both. JDK doclint treats an unresolvable @link as an error (not a warning), so maven-javadoc-plugin:jar (attach-javadocs) exited 1.

javadoc:jar binds to package, which runs before deploy, so nothing was published — the upload never happened and nothing reached the Central Portal. No immutable state to clean up.

Why it was invisible until now

Internal releases publish with -Dmaven.javadoc.skip=true, so javadoc is never built on that path. Public releases must not skip it, because Sonatype rejects a bundle with no -javadoc.jar. So a broken doc link can only surface on a real public release — which is exactly what happened.

The earlier flowvault/v0.0.x rehearsals did run javadoc:jar, but were cut before this class existed.

Fix

One line — correct the two class names. No functional change; comment only.

Verification

mvn --batch-mode -pl flowvault -am -DskipTests javadoc:jar

• Before:BUILD FAILURE, the same two error: reference not found as CI
• After:BUILD SUCCESS — javadoc jar builds for skyflow, common and skyflow-flowvault-java

Verified on JDK 17 (no JDK 11 available locally; the release runs 11). The reference not found doclint check is identical across both, but a JDK 11 confirmation from CI is worth having.

Re-releasing after merge

Re-running the failed job alone won't work — it checks out the same flowvault/v1.0.0 tag and rebuilds the same broken source. The tag needs to move to the fixed commit, or a new tag + Release cut.

The bump side is already safe: 4534e58 [AUTOMATED] Public Release - 1.0.0 is on main with flowvault/pom.xml at 1.0.0, so on retry the Commit changes step takes the pom already at the target version - nothing to commit path and exits 0.

Follow-ups (not in this PR)

1. No PR check builds javadoc, so this whole class of break is only ever caught mid-release. Adding mvn -pl <module> -am javadoc:jar to pr.yml/pr-flowvault.yml would move it left.
2. The same release log shows warning: no @param / no @return on the new Skyflow.builder() timeout/retry methods (timeout, connectTimeout, readTimeout, writeTimeout, maxRetries). Warnings only — they did not fail the build — but worth documenting since they are new public API.

🤖 Generated with Claude Code

[github-actions]

✅ Gitleaks Findings: No secrets detected. Safe to proceed!

[github-actions]

Semgrep Findings: Issues with Error level severity are found (Error is Highest severity in Semgrep), Please resolve the issues before merging.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.30%. Comparing base (4534e58) to head (607eabf).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

@@ Coverage Diff @@## main #400 +/- ##
==========================================
Coverage 91.30% 91.30% - Complexity 0 454 +454 
==========================================
Files 157 157 Lines 6392 6392 Branches 850 850 ==========================================
Hits 5836 5836 Misses 364 364 Partials 192 192 

Flag	Coverage Δ
common	88.38% <ø> (ø)
flowvault	88.65% <ø> (ø)
skyvault	94.72% <ø> (ø)
unittests-flowvault	89.67% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
Module: common	88.38% <ø> (ø)
Module: skyvault	94.72% <ø> (ø)
Module: flowvault	88.65% <ø> (ø)
Service Account	86.69% <ø> (ø)
Vault Data	91.42% <ø> (ø)
Vault Tokens	99.03% <ø> (ø)
Vault Connection	100.00% <ø> (ø)
Vault Controller	85.31% <ø> (ø)
Detect	100.00% <ø> (ø)
Audit	100.00% <ø> (ø)
BIN Lookup	100.00% <ø> (ø)
Config	96.26% <ø> (ø)
Utils	89.21% <ø> (ø)
Errors	100.00% <ø> (ø)
Enums	100.00% <ø> (ø)
Logs	95.32% <ø> (ø)

Files with missing lines	Coverage Δ
.../skyflow/vault/data/BulkTokenizeRequestRecord.java	100.00% <ø> (ø)

---

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4534e58...607eabf. Read the comment docs.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.