Uh oh!
There was an error while loading. Please reload this page.
SK-2977 add beta build disclaimer banner to README on release - #407
Open
Devesh-Skyflow wants to merge 1 commit into
Open
SK-2977 add beta build disclaimer banner to README on release#407Devesh-Skyflow wants to merge 1 commit into
Devesh-Skyflow wants to merge 1 commit into
Conversation
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
✅ Gitleaks Findings: No secrets detected. Safe to proceed! |
Semgrep Findings: Issues with Error level severity are found (Error is Highest severity in Semgrep), Please resolve the issues before merging. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@## main #407 +/- ##
=======================================
Coverage 91.30% 91.30% =======================================
Files 157 157 Lines 6392 6392 Branches 850 850 =======================================
Hits 5836 5836 Misses 364 364 Partials 192 192
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a standard beta/pre-release disclaimer banner to the README, automatically toggled in and out by the existing release automation — part of the CUST-4287 RCA follow-up (SK-2977).
skyvaultandflowvaultversion independently, so the toggle is scoped per module:scripts/toggle_beta_banner.shinserts the banner right after a README's title when the version being released is a-beta.Npre-release, and removes it on GA releases. Idempotent.scripts/bump_version.shagainst$Module/README.md(public/beta path only), andshared-build-and-deploy.ymlnow stages${{ inputs.module }}/README.mdalongsidepom.xml. Askyvaultrelease never touchesflowvault/README.mdand vice versa (verified in review).README.md— a navigation page, not itself a versioned artifact — gets a one-time static note pointing readers to the relevant module's own disclaimer.scripts/toggle_beta_banner.test.shcovers insertion, idempotency, GA removal, and content preservation.This is one of 8 sibling PRs (android, iOS, js, node, python, react-js, react-native, java) rolling out the same disclaimer text and mechanism across the SDKs. skyflow-go is deferred to a follow-up (no release CI to hook into today).
🤖 Generated with Claude Code