Skip to content

SK-2522: Fix Python SDK v2 issues reported in Bug Bash - #231

Merged
saileshwar-skyflow merged 5 commits into
release/26.1.4from
saileshwar/SK-2522-fix-bugs-identified-in-bug-bash
Feb 5, 2026
Merged

SK-2522: Fix Python SDK v2 issues reported in Bug Bash#231
saileshwar-skyflow merged 5 commits into
release/26.1.4from
saileshwar/SK-2522-fix-bugs-identified-in-bug-bash

Conversation

@saileshwar-skyflow

Copy link
Copy Markdown
Collaborator

Why

  • Issues related to Python SDK v2 were identified during the Bug Bash.

  • Fixing them is required to improve reliability and align behavior with expected standards.

Outcome

  • Fixed all Python SDK v2 issues identified in the Bug Bash document.

  • Improved error handling and overall stability of the SDK.

CopilotAI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses multiple issues in the Python SDK v2 identified during the Bug Bash, focusing on error handling, validation logic, and connection invocation functionality.

Changes:

  • Fixed error handling in connection invocation and response parsing to properly handle non-JSON content
  • Corrected validation logic for wait time, credentials, and request parameters
  • Added comprehensive test coverage for new error scenarios and edge cases

Reviewed changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 4 comments.

Show a summary per file
FileDescription
tests/vault/controller/test__connection.pyExpanded test coverage for connection invocation with additional test cases for credentials, error handling, and metadata headers
tests/vault/client/test__client.pyAdded tests for bearer token expiration, reuse, and regeneration scenarios
tests/utils/validations/test__validations.pyUpdated expired token test expectation and added boundary tests for wait time validation
tests/utils/test__utils.pyAdded extensive tests for response parsing, content type handling, error scenarios, and utility functions
skyflow/vault/controller/_connections.pyReordered connection invocation logic to resolve credentials before constructing requests
skyflow/vault/client/client.pyFixed error type for expired token from SyntaxError to SkyflowError
skyflow/utils/validations/_validations.pyFixed validation logic for wait time, credentials, and get request; updated error messages
skyflow/utils/enums/content_types.pyAdded HTML content type enum
skyflow/utils/_utils.pyEnhanced content type handling, fixed response parsing for non-JSON content, improved error handling
skyflow/utils/_skyflow_messages.pyUpdated error messages for consistency and added new EXPIRED_BEARER_TOKEN message

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment threadskyflow/utils/validations/_validations.py Outdated
Comment threadskyflow/utils/_skyflow_messages.py
Comment threadskyflow/utils/_skyflow_messages.py Outdated
Comment threadskyflow/utils/validations/_validations.py
@saileshwar-skyflow
saileshwar-skyflow changed the base branch from himanshu/2496-update-linting-rules-and-fix-hardcoded-values-in-python-v2-sdk to release/26.1.4February 5, 2026 12:25
@saileshwar-skyflow
saileshwar-skyflow merged commit 17399ea into release/26.1.4Feb 5, 2026
4 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@saileshwar-skyflow@skyflow-bharti@aadarsh-st