Skip to content

docs - nested sidebar - #1230

Merged
lukegalbraithrussell merged 1 commit into
mainfrom
docs-nested-nav
Dec 19, 2024
Merged

docs - nested sidebar#1230
lukegalbraithrussell merged 1 commit into
mainfrom
docs-nested-nav

Conversation

@lukegalbraithrussell

Copy link
Copy Markdown
Contributor

Summary

With a slightly smaller font for the sidebar, this gives us some more room to place with spacing. This places all the guides in a uncollapsed "guides" category, to match the deno slack sdk docs format: https://tools.slack.dev/deno-slack-sdk/

It fixes the bolding issues that currently exists because the css was focused on the deno slack sdk docs

This will be important as we look into building out reference docs (as they can all live under a nice "reference" folder)

Testing

You could locally run it! But it works, promise

Category

  • Document pages under /docs

Requirements

Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to those rules.

  • I've read and understood the Contributing Guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • [] I've run ./scripts/install_all_and_run_tests.sh after making the changes.

Comment threaddocs/sidebars.js
},
],
sidebarBoltPy: [
{

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'm assuming this is from the python repo formatting -- 4 spaces is python standard i believe

Comment threaddocs/sidebars.js
Comment on lines +10 to +14
{ type: "html", value: "<hr>" },
{
type: "category",
label: "Guides",
collapsed: false,

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is all i added

@codecov

codecovBot commented Dec 19, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.96%. Comparing base (0c79bb1) to head (dd3c7b9).
Report is 1 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #1230 +/- ##
=======================================
Coverage 90.96% 90.96% =======================================
Files 222 222 Lines 7501 7501 =======================================
Hits 6823 6823 Misses 678 678 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lukegalbraithrussell
lukegalbraithrussell deleted the docs-nested-nav branch December 19, 2024 15:08
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@lukegalbraithrussell@technically-tracy