Skip to content

Docs: Reorganize nav to match Bolt JS follow-up. - #1242

Merged
technically-tracy merged 6 commits into
mainfrom
tracy-nav-updates
Feb 4, 2025
Merged

Docs: Reorganize nav to match Bolt JS follow-up.#1242
technically-tracy merged 6 commits into
mainfrom
tracy-nav-updates

Conversation

@technically-tracy

@technically-tracytechnically-tracy commented Jan 31, 2025

Copy link
Copy Markdown
Contributor

Summary

Follow-up tasks:

  • Combined the two types of getting-started guides (http and socket mode), in both languages.
  • Added Japanese nav category labels where possible.
  • A few tweaks to side nav wording to align with Bolt JS.

Category

  • slack_bolt.App and/or its core components
  • slack_bolt.async_app.AsyncApp and/or its core components
  • Adapters in slack_bolt.adapter
  • Document pages under /docs
  • Others

Requirements

Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to those rules.

  • I've read and understood the Contributing Guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've run ./scripts/install_all_and_run_tests.sh after making the changes.

@codecov

codecovBot commented Jan 31, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.96%. Comparing base (0a32319) to head (cf7b0be).
Report is 1 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #1242 +/- ##
=======================================
Coverage 90.96% 90.96% =======================================
Files 222 222 Lines 7501 7501 =======================================
Hits 6823 6823 Misses 678 678 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Comment threaddocs/content/getting-started.md Outdated
Comment threaddocs/content/getting-started.md Outdated

@lukegalbraithrusselllukegalbraithrussell left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small change, but looks good! I'm adding @seratch as a reviewer in case he wants to look over the consolidated Japanese Getting Started guide

@mwbrooksmwbrooks added the docs Improvements or additions to documentation label Jan 31, 2025
@mwbrooksmwbrooks added this to the 1.22.1 milestone Jan 31, 2025

@seratchseratch left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I've added a few suggestions for the Japanese labels. Other than that, everything looks great

Comment threaddocs/i18n/ja-jp/docusaurus-plugin-content-docs/current.json Outdated
Comment threaddocs/i18n/ja-jp/docusaurus-plugin-content-docs/current.json Outdated
Comment threaddocs/i18n/ja-jp/docusaurus-plugin-content-docs/current.json Outdated
@technically-tracy
technically-tracy merged commit 27358b4 into mainFeb 4, 2025
@technically-tracy
technically-tracy deleted the tracy-nav-updates branch February 4, 2025 18:17
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docsImprovements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@technically-tracy@seratch@lukegalbraithrussell@mwbrooks