Uh oh!
There was an error while loading. Please reload this page.
chore(deps): update pytest-asyncio requirement from <1 to <2 - #1329
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@## main #1329 +/- ##
=======================================
Coverage 90.54% 90.54% =======================================
Files 222 222 Lines 7129 7129 =======================================
Hits 6455 6455 Misses 674 674 ☔ View full report in Codecov by Sentry. |
b8abe0e to
2964ac2Compareadddd4a to
0875cfdCompareUpdates the requirements on [pytest-asyncio](https://github.com/pytest-dev/pytest-asyncio) to permit the latest version. - [Release notes](https://github.com/pytest-dev/pytest-asyncio/releases) - [Commits](pytest-dev/pytest-asyncio@v0.1.1...v1.0.0) --- updated-dependencies: - dependency-name: pytest-asyncio dependency-version: 1.0.0 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
0875cfd to
91b1953CompareWilliamBergamin
commented
Aug 1, 2025
@dependabot rebase |
Looks like this PR has been edited by someone other than Dependabot. That means Dependabot can't rebase it - sorry! If you're happy for Dependabot to recreate it from scratch, overwriting any edits, you can request |
WilliamBergamin
commented
Sep 9, 2025
@dependabot recreate |
WilliamBergamin
left a comment
There was a problem hiding this comment.
I've updated this PR so that the async test follow the more classic setup, teardownpattern
Previously this project was using a pytest fixture to configure and return the "event loop". This pattern is not supported by pytest-asyncio 1.x.
zimeg
left a comment
There was a problem hiding this comment.
@WilliamBergamin Thanks so much for these improvements to the test suite!
IIRC the event loop was causing frequent warnings and this setup|teardown pattern is nice - LGTM! 👾 ✨
| def get_event_loop(): | ||
| try: | ||
| return asyncio.get_event_loop() | ||
| except RuntimeError as ex: | ||
| if "There is no current event loop in thread" in str(ex): | ||
| loop = asyncio.new_event_loop() | ||
| asyncio.set_event_loop(loop) | ||
| return loop |
There was a problem hiding this comment.
🪓 praise: Farewell the testing event loop in the utils file!
Uh oh!
There was an error while loading. Please reload this page.
Rebasing might not happen immediately, so don't worry if this takes some time.
Note: if you make any changes to this PR yourself, they will take precedence over the rebase.
Updates the requirements on pytest-asyncio to permit the latest version.
Release notes
Sourced from pytest-asyncio's releases.
Commits
5ef97bdchore: Prepare release of v1.0.0.f212e24docs: Mention fix of #797.32c1d10test: Removed obsolete test for async_gen_fixtures.627ce92[pre-commit.ci] pre-commit autoupdatea55ff36Build(deps): Bump pluggy from 1.5.0 to 1.6.0 in /dependencies/default633389fBuild(deps): Bump hypothesis in /dependencies/default0c99466docs: Fixed an error that reported a missing event_loop fixture when using pa...0688d17ci: Replace Github template expansion with env variable expansion.2adcf52ci: Quote Github variable expansion.dd0fac9ci: Fixed a bug that prevented release notes from being extracted from a Git ...You can trigger a rebase of this PR by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)