Skip to content

build(deps): remove pytest lower bounds from testing requirements - #1333

Merged
zimeg merged 3 commits into
mainfrom
zimeg-build-pytest-requirement-lower-bound
Sep 26, 2025
Merged

build(deps): remove pytest lower bounds from testing requirements#1333
zimeg merged 3 commits into
mainfrom
zimeg-build-pytest-requirement-lower-bound

Conversation

@zimeg

@zimegzimeg commented Jul 7, 2025

Copy link
Copy Markdown
Member

Summary

This PR removes the lower bounds of pytest following discussion in #1328 to support active versions 🚢 💨

Testing

🤖 In ci runs to follow.

Category

  • Others

Requirements

Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to those rules.

  • I've read and understood the Contributing Guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've run ./scripts/install_all_and_run_tests.sh after making the changes.

@zimegzimeg self-assigned this Jul 7, 2025
@zimegzimeg added dependencies Pull requests that update a dependency file tests labels Jul 7, 2025
@codecov

codecovBot commented Jul 7, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.00%. Comparing base (811d6a2) to head (dcb2b1e).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@ Coverage Diff @@## main #1333 +/- ##
=======================================
Coverage 91.00% 91.00% =======================================
Files 222 222 Lines 7512 7512 =======================================
Hits 6836 6836 Misses 676 676 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@WilliamBergaminWilliamBergamin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work 💯

Just want to point out that we still officially support 3.6, but if we merge this change we may have issues testing with 3.6 locally, so we should drop official support for it in our next release

Other lower bound requirements are also present specifically for 3.6 it may be worth looking into them

@zimeg

Copy link
Copy Markdown
MemberAuthor

@WilliamBergamin@ewanek1 Thank y'all both for the reviews!

Just want to point out that we still officially support 3.6, but if we merge this change we may have issues testing with 3.6 locally, so we should drop official support for it in our next release

This is a great callout that caused me to hold off on merging this for now - I'm not aware of the other changes needed to drop official 3.6 support.

If this can merge as is I think that'd be ideal, but please let me know if we should hold off more 🤖

@zimegzimeg added this to the 1.25.1 milestone Sep 26, 2025
@zimeg

Copy link
Copy Markdown
MemberAuthor

@WilliamBergamin@ewanek1 Once again I appreciate the notice and reviews. I've added this to a milestone so we can keep track of which version we removed this bounds in 🎁

@zimeg
zimeg merged commit e21c4e8 into mainSep 26, 2025
15 checks passed
@zimeg
zimeg deleted the zimeg-build-pytest-requirement-lower-bound branch September 26, 2025 00:57
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependenciesPull requests that update a dependency filetests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@zimeg@WilliamBergamin@ewanek1