Skip to content

ci: post regression notifications if scheduled tests do not succeed - #1376

Merged
zimeg merged 7 commits into
mainfrom
zimeg-ci-test-notificiations-errors
Sep 30, 2025
Merged

ci: post regression notifications if scheduled tests do not succeed#1376
zimeg merged 7 commits into
mainfrom
zimeg-ci-test-notificiations-errors

Conversation

@zimeg

Copy link
Copy Markdown
Member

Summary

This PR follows #1374 and #1375 to send regression notifications if scheduled tests do not succeed instead of just during failures. Fixes an issue where test timeout did not post a message.

Testing

📺 Planning to add a few commits that confirm !success is the correct operation for both "cancelled" and "failure" states. Since these steps run when scheduled on "main" outside of this PR, these are both events we want to capture I believe.

Category

  • Others

Requirements

Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to those rules.

  • I've read and understood the Contributing Guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've run ./scripts/install_all_and_run_tests.sh after making the changes.

@zimegzimeg self-assigned this Sep 26, 2025
@zimegzimeg added github_actions Pull requests that update GitHub Actions code tests labels Sep 26, 2025
@codecov

codecovBot commented Sep 26, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.00%. Comparing base (9fa6e86) to head (e768b0c).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@ Coverage Diff @@## main #1376 +/- ##
=======================================
Coverage 91.00% 91.00% =======================================
Files 222 222 Lines 7512 7512 =======================================
Hits 6836 6836 Misses 676 676 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zimeg

Copy link
Copy Markdown
MemberAuthor

@mwbrooksmwbrooks left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great idea!

@zimeg

Copy link
Copy Markdown
MemberAuthor

@mwbrooks Kind appreciation in the iterations against regression - let's now merge this! 🤖

@zimeg
zimeg enabled auto-merge (squash) September 30, 2025 18:47
@zimeg
zimeg merged commit cb4130a into mainSep 30, 2025
13 checks passed
@zimeg
zimeg deleted the zimeg-ci-test-notificiations-errors branch September 30, 2025 20:27
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

github_actionsPull requests that update GitHub Actions codetests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@zimeg@mwbrooks