Uh oh!
There was an error while loading. Please reload this page.
fix(types): accept a sequence of suggested prompts in assistant context - #1382
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@## ai-apps #1382 +/- ##
==========================================
Coverage ? 91.03% ==========================================
Files ? 222 Lines ? 7514 Branches ? 0 ==========================================
Hits ? 6840 Misses ? 674 Partials ? 0 ☔ View full report in Codecov by Sentry. |
WilliamBergamin
approved these changes
Oct 3, 2025
WilliamBergamin
left a comment
Contributor
There was a problem hiding this comment.
Nice catch 💯
Praise the testing 🚀
zimeg
commented
Oct 3, 2025
MemberAuthor
@WilliamBergamin@mwbrooks Thanks! I'm finding |
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR accepts a sequence of suggested prompts in the
assistantcontext. Fixes an issue where mypy complained about invalid types:https://github.com/slack-samples/bolt-python-assistant-template/blob/ec9fb79117fb52bf3ccf0238d242af11ee50807f/listeners/assistant/assistant.py#L51
Testing
This error should vanish when using this build without changing app functionalities!
Category
slack_bolt.Appand/or its core componentsslack_bolt.async_app.AsyncAppand/or its core componentsRequirements
Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to those rules.
./scripts/install_all_and_run_tests.shafter making the changes.