Skip to content

fix: pin setuptools to maintain support for pyramid adapter - #1436

Merged
vegeris merged 1 commit into
mainfrom
pin-setup-tool-for-pyramid
Feb 11, 2026
Merged

fix: pin setuptools to maintain support for pyramid adapter#1436
vegeris merged 1 commit into
mainfrom
pin-setup-tool-for-pyramid

Conversation

@WilliamBergamin

Copy link
Copy Markdown
Contributor

Summary

The pyramid framework is dependent on setuptoolspkg_resources module. This module has been deprecated since setuptools v67.5.0 and removed in setuptools v82.0.0. See Pylons/pyramid#3731 for all the details.

These changes pins setuptools v82.0.0 when unit testing the project in order to allow the tests around the Pyramid Adapter to run.

When pyramids dependence on pkg_resources is resolved we should remove the setuptools v82.0.0 pin.

Testing

Continuous integration tests should be sufficient

You can also pull this branch and run the tests locally, everything should pass

Category

  • slack_bolt.App and/or its core components
  • slack_bolt.async_app.AsyncApp and/or its core components
  • Adapters in slack_bolt.adapter
  • Document pages under /docs
  • Others

Requirements

Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to those rules.

  • I've read and understood the Contributing Guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've run ./scripts/install_all_and_run_tests.sh after making the changes.

@WilliamBergaminWilliamBergamin added this to the 1.27.1 milestone Feb 10, 2026
@WilliamBergaminWilliamBergamin self-assigned this Feb 10, 2026
@WilliamBergamin
WilliamBergamin requested a review from a team as a code ownerFebruary 10, 2026 18:01
@WilliamBergaminWilliamBergamin added bug Something isn't working area:adapter dependencies Pull requests that update a dependency file semver:patch labels Feb 10, 2026
@codecov

codecovBot commented Feb 10, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.54%. Comparing base (e5cf0f7) to head (afc302c).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@ Coverage Diff @@## main #1436 +/- ##
=======================================
Coverage 90.54% 90.54% =======================================
Files 222 222 Lines 7129 7129 =======================================
Hits 6455 6455 Misses 674 674 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vegerisvegeris left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks for making this update!

@vegeris
vegeris merged commit 868cedb into mainFeb 11, 2026
16 checks passed
@vegeris
vegeris deleted the pin-setup-tool-for-pyramid branch February 11, 2026 00:43
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:adapterbugSomething isn't workingdependenciesPull requests that update a dependency filesemver:patch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@WilliamBergamin@vegeris