Uh oh!
There was an error while loading. Please reload this page.
fix(agent): match channel_id api argument for set_status and set_suggested_prompts - #1446
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@## main #1446 +/- ##
=======================================
Coverage 90.67% 90.67% =======================================
Files 226 226 Lines 7205 7205 =======================================
Hits 6533 6533 Misses 672 672 ☔ View full report in Codecov by Sentry. |
mwbrooks
left a comment
There was a problem hiding this comment.
✅ Thanks for the detailed eye @zimeg!
👍🏻 I agree with your approach - consistency is important. If we're naming the helper methods similar to the original method, then we should keep the arguments consistent. Plus _id is just better 😉
zimeg
commented
Feb 19, 2026
@mwbrooks We share this thought! Thanks so much for the review! Without |
Uh oh!
There was an error while loading. Please reload this page.
Summary
This PR follows #1441 and #1442 with updates to
channel_idto match the API arguments for these methods:I forget if this was meant to match the chat_stream arguments, which is
channelstill, but matching the API arguments might make references most clear I think!Category
slack_bolt.Appand/or its core componentsslack_bolt.async_app.AsyncAppand/or its core componentsRequirements
Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to those rules.
./scripts/install_all_and_run_tests.shafter making the changes.