Skip to content

fix(agent): match channel_id api argument for set_status and set_suggested_prompts - #1446

Merged
zimeg merged 1 commit into
mainfrom
zimeg-fix-agent-api-arguments
Feb 19, 2026
Merged

fix(agent): match channel_id api argument for set_status and set_suggested_prompts#1446
zimeg merged 1 commit into
mainfrom
zimeg-fix-agent-api-arguments

Conversation

@zimeg

Copy link
Copy Markdown
Member

Summary

This PR follows #1441 and #1442 with updates to channel_id to match the API arguments for these methods:

I forget if this was meant to match the chat_stream arguments, which is channel still, but matching the API arguments might make references most clear I think!

Category

  • slack_bolt.App and/or its core components
  • slack_bolt.async_app.AsyncApp and/or its core components

Requirements

Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to those rules.

  • I've read and understood the Contributing Guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've run ./scripts/install_all_and_run_tests.sh after making the changes.

@zimegzimeg self-assigned this Feb 19, 2026
@zimeg
zimeg requested a review from a team as a code ownerFebruary 19, 2026 03:44
@zimegzimeg added bug Something isn't working semver:patch experiment Experimental feature documented with ExperimentalWarning and pydoc Experiment section labels Feb 19, 2026
@codecov

codecovBot commented Feb 19, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.67%. Comparing base (d789fac) to head (1edf454).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@ Coverage Diff @@## main #1446 +/- ##
=======================================
Coverage 90.67% 90.67% =======================================
Files 226 226 Lines 7205 7205 =======================================
Hits 6533 6533 Misses 672 672 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mwbrooksmwbrooks left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Thanks for the detailed eye @zimeg!

👍🏻 I agree with your approach - consistency is important. If we're naming the helper methods similar to the original method, then we should keep the arguments consistent. Plus _id is just better 😉

@zimeg

Copy link
Copy Markdown
MemberAuthor

@mwbrooks We share this thought! Thanks so much for the review! Without id I'm also not sure if an object is needed instead... So let's merge this! 🚢 💨

@zimeg
zimeg merged commit 837e120 into mainFeb 19, 2026
16 checks passed
@zimeg
zimeg deleted the zimeg-fix-agent-api-arguments branch February 19, 2026 19:28
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugSomething isn't workingexperimentExperimental feature documented with ExperimentalWarning and pydoc Experiment sectionsemver:patch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@zimeg@mwbrooks