Skip to content

chore: improve testing around assistant utilities - #1461

Merged
WilliamBergamin merged 3 commits into
mainfrom
imporve-assistant-behavior-test-coverage
Mar 17, 2026
Merged

chore: improve testing around assistant utilities#1461
WilliamBergamin merged 3 commits into
mainfrom
imporve-assistant-behavior-test-coverage

Conversation

@WilliamBergamin

Copy link
Copy Markdown
Contributor

Summary

These changes aim to improve the coverage of tests around the assistant utilities

Testing

CI should be sufficient

Category

  • slack_bolt.App and/or its core components
  • slack_bolt.async_app.AsyncApp and/or its core components
  • Adapters in slack_bolt.adapter
  • Document pages under /docs
  • Others

Requirements

Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to those rules.

  • I've read and understood the Contributing Guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've run ./scripts/install_all_and_run_tests.sh after making the changes.

@codecov

codecovBot commented Mar 16, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.89%. Comparing base (898e0b8) to head (5a75303).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@ Coverage Diff @@## main #1461 +/- ##
==========================================
+ Coverage 90.67% 90.89% +0.22% 
==========================================
Files 226 226 Lines 7205 7205 ==========================================
+ Hits 6533 6549 +16 + Misses 672 656 -16 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zimegzimeg left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@WilliamBergamin LGTM! These are nice tests to build confidence in current implementation 🧪 ✨

@WilliamBergamin
WilliamBergamin merged commit f0db283 into mainMar 17, 2026
16 checks passed
@WilliamBergamin
WilliamBergamin deleted the imporve-assistant-behavior-test-coverage branch March 17, 2026 13:21
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@WilliamBergamin@zimeg