Skip to content

chore: fix test warnings across test suite - #1468

Merged
WilliamBergamin merged 9 commits into
mainfrom
fix-some-test-warnings
Mar 23, 2026
Merged

chore: fix test warnings across test suite #1468
WilliamBergamin merged 9 commits into
mainfrom
fix-some-test-warnings

Conversation

@WilliamBergamin

Copy link
Copy Markdown
Contributor

Summary

This PR aims to fix some warnings that were showing up in our unit tests 🙏

Testing

CI should be sufficient

Category

  • slack_bolt.App and/or its core components
  • slack_bolt.async_app.AsyncApp and/or its core components
  • Adapters in slack_bolt.adapter
  • Document pages under /docs
  • Others

Requirements

Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to those rules.

  • I've read and understood the Contributing Guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've run ./scripts/install_all_and_run_tests.sh after making the changes.

@WilliamBergaminWilliamBergamin added this to the 1.28.0 milestone Mar 20, 2026
@WilliamBergaminWilliamBergamin self-assigned this Mar 20, 2026
@WilliamBergamin
WilliamBergamin requested a review from a team as a code ownerMarch 20, 2026 16:43
@WilliamBergaminWilliamBergamin added python Pull requests that update Python code tests semver:patch labels Mar 20, 2026
@codecov

codecovBot commented Mar 20, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.31%. Comparing base (6e57716) to head (edd539f).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@ Coverage Diff @@## main #1468 +/- ##
=======================================
Coverage 91.31% 91.31% =======================================
Files 229 229 Lines 7266 7266 =======================================
Hits 6635 6635 Misses 631 631 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zimegzimeg left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@WilliamBergamin Another amazing change in care for this project 🧪 ✨

Please merge when's right but I left a curious question if the answer is quick-

Comment on lines +4 to +5
"ENGINE": "django.db.backends.sqlite3",
"NAME": "logs/db.sqlite3",
"NAME": ":memory:",

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👁️‍🗨️ question: Does this sqlite implementation not use the file system? I haven't explored these tests much but found this surprising at glance!

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point I found another way to silence the django warning 🙏

@WilliamBergamin
WilliamBergamin merged commit 98a8f59 into mainMar 23, 2026
16 checks passed
@WilliamBergamin
WilliamBergamin deleted the fix-some-test-warnings branch March 23, 2026 16:07
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pythonPull requests that update Python codesemver:patchtests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@WilliamBergamin@zimeg