Skip to content

fix: mock module level time to improve stability - #1497

Merged
WilliamBergamin merged 1 commit into
mainfrom
fix-flakiness-in-unit-tests
May 11, 2026
Merged

fix: mock module level time to improve stability#1497
WilliamBergamin merged 1 commit into
mainfrom
fix-flakiness-in-unit-tests

Conversation

@WilliamBergamin

Copy link
Copy Markdown
Contributor

Summary

These changes aim to improve the stability of our unit tests by mocking time a the module level rather then the global level, it also provides more roust implementations of the time and sleep mocks

Testing

CI should be sufficient

Category

  • slack_bolt.App and/or its core components
  • slack_bolt.async_app.AsyncApp and/or its core components
  • Adapters in slack_bolt.adapter
  • Document pages under /docs
  • Others

Requirements

Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to those rules.

  • I've read and understood the Contributing Guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've run ./scripts/install_all_and_run_tests.sh after making the changes.

@codecov

codecovBot commented May 11, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.32%. Comparing base (ae0ba57) to head (00da303).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@ Coverage Diff @@## main #1497 +/- ##
=======================================
Coverage 91.32% 91.32% =======================================
Files 228 228 Lines 7262 7262 =======================================
Hits 6632 6632 Misses 630 630 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zimegzimeg left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@WilliamBergamin LGTM or hawschoooo 😴

@WilliamBergamin
WilliamBergamin merged commit 07fb589 into mainMay 11, 2026
16 checks passed
@WilliamBergamin
WilliamBergamin deleted the fix-flakiness-in-unit-tests branch May 11, 2026 16:27
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@WilliamBergamin@zimeg