Skip to content

Make team_id optional for admin_users_list - #1725

Merged
hello-ashleyintech merged 3 commits into
mainfrom
ah-fix-issue-1724
Aug 6, 2025
Merged

Make team_id optional for admin_users_list#1725
hello-ashleyintech merged 3 commits into
mainfrom
ah-fix-issue-1724

Conversation

@hello-ashleyintech

Copy link
Copy Markdown
Contributor

Summary

This PR fixes issue #1724 and changes the team_id param to optional in the Python SDK. It is marked as optional in the public facing API docs: https://api.slack.com/methods/admin.users.list

Category

  • slack_sdk.web.WebClient (sync/async) (Web API client)
  • slack_sdk.webhook.WebhookClient (sync/async) (Incoming Webhook, response_url sender)
  • slack_sdk.socket_mode (Socket Mode client)
  • slack_sdk.signature (Request Signature Verifier)
  • slack_sdk.oauth (OAuth Flow Utilities)
  • slack_sdk.models (UI component builders)
  • slack_sdk.scim (SCIM API client)
  • slack_sdk.audit_logs (Audit Logs API client)
  • slack_sdk.rtm_v2 (RTM client)
  • /docs (Documents)
  • /tutorial (PythOnBoardingBot tutorial)
  • tests/integration_tests (Automated tests for this library)

Requirements

  • I've read and understood the Contributing Guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've run python3 -m venv .venv && source .venv/bin/activate && ./scripts/run_validation.sh after making the changes.

@hello-ashleyintechhello-ashleyintech self-assigned this Aug 5, 2025
@hello-ashleyintechhello-ashleyintech added enhancement M-T: A feature request for new functionality bug M-T: A confirmed bug report. Issues are confirmed when the reproduction steps are documented web-client and removed enhancement M-T: A feature request for new functionality labels Aug 5, 2025
@codecov

codecovBot commented Aug 5, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.88%. Comparing base (b401e58) to head (c28d284).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@ Coverage Diff @@## main #1725 +/- ##
==========================================
- Coverage 84.91% 84.88% -0.04% 
==========================================
Files 113 113 Lines 12895 12895 ==========================================
- Hits 10950 10946 -4 - Misses 1945 1949 +4 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@WilliamBergaminWilliamBergamin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me 🚀 thanks for putting this together

@WilliamBergaminWilliamBergamin added this to the 3.37.0 milestone Aug 6, 2025
@hello-ashleyintech
hello-ashleyintech merged commit d238bd6 into mainAug 6, 2025
12 checks passed
@hello-ashleyintech
hello-ashleyintech deleted the ah-fix-issue-1724 branch August 6, 2025 17:46
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugM-T: A confirmed bug report. Issues are confirmed when the reproduction steps are documentedweb-client

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@hello-ashleyintech@WilliamBergamin