Skip to content

fix(web-api): use json content type for chat stream methods - #1749

Merged
zimeg merged 4 commits into
ai-appsfrom
zimeg-fix-web-api-chat-stream-json
Sep 23, 2025
Merged

fix(web-api): use json content type for chat stream methods#1749
zimeg merged 4 commits into
ai-appsfrom
zimeg-fix-web-api-chat-stream-json

Conversation

@zimeg

Copy link
Copy Markdown
Member

Summary

This PR follows #1745 to use json instead of params as the content type for chat stream methods. Reference.

Fixes an issue where nested attributes - such as blocks - weren't parsed as expected. 🐛

Category

  • slack_sdk.web.WebClient (sync/async) (Web API client)

Requirements

  • I've read and understood the Contributing Guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've run python3 -m venv .venv && source .venv/bin/activate && ./scripts/run_validation.sh after making the changes.

@zimegzimeg self-assigned this Sep 23, 2025
@zimegzimeg added bug M-T: A confirmed bug report. Issues are confirmed when the reproduction steps are documented semver:patch web-client labels Sep 23, 2025
@codecov

codecovBot commented Sep 23, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (ai-apps@8519684). Learn more about missing BASE report.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@ Coverage Diff @@## ai-apps #1749 +/- ##
==========================================
Coverage ? 84.98% ==========================================
Files ? 113 Lines ? 12944 Branches ? 0 ==========================================
Hits ? 11000 Misses ? 1944 Partials ? 0 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mwbrooksmwbrooks left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Looking good @zimeg! Thanks for following up on the previous PR feedback!

@zimeg

Copy link
Copy Markdown
MemberAuthor

@mwbrooks Appreciate it! Let's merge this with passing tests to unblock findings elsewhere 🧪 ✨

@zimeg
zimeg merged commit 16741f8 into ai-appsSep 23, 2025
12 checks passed
@zimeg
zimeg deleted the zimeg-fix-web-api-chat-stream-json branch September 23, 2025 04:51
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugM-T: A confirmed bug report. Issues are confirmed when the reproduction steps are documentedsemver:patchweb-client

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@zimeg@mwbrooks