Uh oh!
There was an error while loading. Please reload this page.
fix(web): send structured values to "assistant.threads.setStatus" method using json content type - #1754
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@## ai-apps #1754 +/- ##
==========================================
Coverage ? 85.02% ==========================================
Files ? 113 Lines ? 12958 Branches ? 0 ==========================================
Hits ? 11017 Misses ? 1941 Partials ? 0 ☔ View full report in Codecov by Sentry. |
zimeg
commented
Sep 30, 2025
@mwbrooks This is a good call. I'll take a pass at this before merging:
python-slack-sdk/slack_sdk/web/client.py Line 2077 in 262a7b9
python-slack-sdk/slack_sdk/web/client.py Line 2635 in 262a7b9
python-slack-sdk/slack_sdk/web/client.py Line 2894 in 262a7b9
python-slack-sdk/slack_sdk/web/client.py Line 2920 in 262a7b9 📚 AFAICT other methods can require either |
zimeg
commented
Sep 30, 2025
Uh oh!
There was an error while loading. Please reload this page.
Summary
This PR uses the JSON content type to send structured values, such as an array of
loading_messagesto the server with correct encodings 🤖Testing
Test cases now include arguments that require this
jsoncontent type!Category
tests/integration_tests(Automated tests for this library)Requirements
python3 -m venv .venv && source .venv/bin/activate && ./scripts/run_validation.shafter making the changes.