Uh oh!
There was an error while loading. Please reload this page.
docs(oauth): use a variable "base_dir" home path for file stores - #1760
Conversation
zimeg
left a comment
There was a problem hiding this comment.
📬 A note on change for reviewers!
| rm -rf docs/reference | ||
| pdoc slack_sdk --html -o docs/reference |
There was a problem hiding this comment.
🗣️ note: This change keeps this script consistent going forward! As far as I can tell, overriding the HOME variable causes no problem for pdoc or reference.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@## main #1760 +/- ##
=======================================
Coverage 85.15% 85.15% =======================================
Files 115 115 Lines 13068 13068 =======================================
Hits 11128 11128 Misses 1940 1940 ☔ View full report in Codecov by Sentry. |
WilliamBergamin
left a comment
There was a problem hiding this comment.
Clever solution 💯 🚀
| rm -rf docs/reference | ||
| pdoc slack_sdk --html -o docs/reference |
| rm -rf docs/reference | ||
| pdoc slack_sdk --html -o docs/reference |
1503cb8 to
6337dddComparezimeg
commented
Oct 16, 2025
@WilliamBergamin@mwbrooks Thanks both for the kind reviews! 👾 ✨ I had to change the base branch after rushing to put this PR up, but the same changes remains so I will merge this now 📚 |
Summary
This PR replaces the
base_dirdefault shown in documentation to use the "$HOME" placeholder instead of a particular path. Fixes#1752.Testing
No changes to functionalities! The docs I hope are more clear with this change too 📚
Notes
Category
/docs(Documents)Requirements
python3 -m venv .venv && source .venv/bin/activate && ./scripts/run_validation.shafter making the changes.