Uh oh!
There was an error while loading. Please reload this page.
fix(web-api): remove unfurl arguments from chat.startStream method - #1761
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@## ai-apps #1761 +/- ##
==========================================
Coverage ? 85.15% ==========================================
Files ? 115 Lines ? 13068 Branches ? 0 ==========================================
Hits ? 11128 Misses ? 1940 Partials ? 0 ☔ View full report in Codecov by Sentry. |
mwbrooks
left a comment
There was a problem hiding this comment.
✅ Looks good!
🧪 Since this is an unreleased method, we shouldn't be concerned about breaking any apps as well.
zimeg
commented
Oct 2, 2025
@mwbrooks Awesome! Thanks for the kind review. IMHO removing arguments that don't exist with the API, even after released, might be considered a non-breaking change anyways since the changing method wouldn't accept the argument. For now, I'm glad we caught this sooner! 🚢 💨 |
Uh oh!
There was an error while loading. Please reload this page.
Summary
This PR removes
unfurl_linksandunfurl_mediaarguments from the "chat.startStream" method to align with the backend.Testing
Calls without these arguments should continue to succeed.
Category
/docs(Documents)Requirements
python3 -m venv .venv && source .venv/bin/activate && ./scripts/run_validation.shafter making the changes.