Skip to content

ci: send regression notifications if prior jobs do not succeed on schedule - #1768

Merged
zimeg merged 5 commits into
mainfrom
zimeg-ci-regressions
Oct 20, 2025
Merged

ci: send regression notifications if prior jobs do not succeed on schedule#1768
zimeg merged 5 commits into
mainfrom
zimeg-ci-regressions

Conversation

@zimeg

Copy link
Copy Markdown
Member

Summary

This PR adds scheduled regression tests to CI for earlier alerts if dependencies cause builds to break.

Testing

Following commits will be used as a proof of concept!

Category

  • tests/integration_tests (Automated tests for this library)

Requirements

  • I've read and understood the Contributing Guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've run python3 -m venv .venv && source .venv/bin/activate && ./scripts/run_validation.sh after making the changes.

@zimegzimeg added this to the 3.38.0 milestone Oct 16, 2025
@zimegzimeg self-assigned this Oct 16, 2025
@zimegzimeg added tests M-T: Testing work only semver:patch labels Oct 16, 2025
@zimeg

Copy link
Copy Markdown
MemberAuthor

🗣️ We might be failing a test already! But the ordering of these jobs seems alright to me:

workflows

🔗 https://github.com/slackapi/python-slack-sdk/pull/1768/checks

@zimeg

Copy link
Copy Markdown
MemberAuthor

📝 I notice a handful of required checks don't match the updated steps - if these changes seem alright we can perhaps update what's required to match?

@codecov

codecovBot commented Oct 16, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.12%. Comparing base (344e0c5) to head (db74dec).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@ Coverage Diff @@## main #1768 +/- ##
=======================================
Coverage 85.12% 85.12% =======================================
Files 115 115 Lines 13068 13068 =======================================
Hits 11124 11124 Misses 1944 1944 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zimeg
zimeg requested a review from vegerisOctober 16, 2025 00:57
@mwbrooks

Copy link
Copy Markdown
Member

🗣️ We might be failing a test already! But the ordering of these jobs seems alright to me:

Any idea why these are failing? The PR looks straight forward, but is it introducing these failures?

@zimeg

Copy link
Copy Markdown
MemberAuthor

Any idea why these are failing? The PR looks straight forward, but is it introducing these failures?

@mwbrooks I had to investigate this and I believe the changes of #1769 might be promising in resolving this! Let's find out soon 👁️‍🗨️

@WilliamBergaminWilliamBergamin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 💯 I like this improvement to our CI

Comment on lines +98 to +101
needs:
- typecheck
- unittest
if: ${{ !success() && github.ref == 'refs/heads/main' && github.event_name != 'workflow_dispatch' }}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Praise 🙏

@WilliamBergamin

Copy link
Copy Markdown
Contributor

The branch rules were updated to match the new Jobs names 💯 we will need to merge this PR before merging other changes

@zimeg

Copy link
Copy Markdown
MemberAuthor

@mwbrooks@WilliamBergamin Thanks both for the reviews and help in improvements to these checks! 🧪 ✨

I'll merge this once tests are passing to unblock other jobs - will monitor these scheduled runs later ⏳

@zimeg
zimeg enabled auto-merge (squash) October 20, 2025 17:37
@zimeg
zimeg merged commit e9e64d8 into mainOct 20, 2025
13 checks passed
@zimeg
zimeg deleted the zimeg-ci-regressions branch October 20, 2025 17:41
@zimeg

Copy link
Copy Markdown
MemberAuthor

⏳ Nice! This seems to've started as we hope: https://github.com/slackapi/python-slack-sdk/actions/runs/18668441391

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

semver:patchtestsM-T: Testing work only

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@zimeg@mwbrooks@WilliamBergamin